This repository has been archived by the owner on Feb 8, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves us to a more thread-safe streaming while still maintaining as much performance as possible. To do this, we use a few tricks:
im
currently. This should let us share the existing declarations more cheaply among the iteration steps without large amounts of copying or locking. This also lets us still access the declarations via id without an lockingPipelineData
as the input and output of commands, an enum that is either a Stream or a ValueEvaluationContext
into theEngineState
andStack
components, as the latter needs to be passed mutably for the above. The end result is now every command has one additional parameter and we've simplified away the previous context structure.TODO: