Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added support for symmetric loss #308

Closed
wants to merge 1 commit into from

Conversation

rum1887
Copy link

@rum1887 rum1887 commented Oct 8, 2023

Signed-off-by: Ramya [email protected]

Adds support for a few more symmetric loss functions.

Fixes #71

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Merging #308 (ba93f2e) into main (64c2e95) will decrease coverage by 0.25%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #308      +/-   ##
==========================================
- Coverage   94.10%   93.85%   -0.25%     
==========================================
  Files          77       77              
  Lines        3495     3501       +6     
  Branches      280      283       +3     
==========================================
- Hits         3289     3286       -3     
- Misses        156      161       +5     
- Partials       50       54       +4     
Files Coverage Δ
numalogic/models/vae/base.py 82.05% <0.00%> (-14.92%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rum1887 rum1887 marked this pull request as draft October 9, 2023 10:52
@rum1887 rum1887 marked this pull request as ready for review October 9, 2023 19:11
@s0nicboOm
Copy link
Contributor

Hi @rum1887 !
Added a comment to the issue and expectations.
#71 (comment)

@s0nicboOm s0nicboOm marked this pull request as draft November 16, 2023 22:08
@ab93
Copy link
Member

ab93 commented Feb 5, 2024

Closing this for now since the issue was updated!

@ab93 ab93 closed this Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Loss Functions (Symmetric Loss function)
3 participants