Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable restful daemon client option for UX server #1826

Merged
merged 6 commits into from
Jul 15, 2024

Conversation

whynowy
Copy link
Member

@whynowy whynowy commented Jul 15, 2024

Added an option to use RESTful client to access daemon service.

  ### The protocol used to connect to the Pipeline daemon service from Numaflow UX server.
  #   Could be either 'grpc' or 'http', defaults to 'grpc'.
  # 
  # server.daemon.client.protocol: grpc

This is useful when there's a breaking change on daemon service protobuf, while the pipeline can not run the same version of code as the UX server (e.g. UX server is installed in cluster scope, while controllers are in namespace scope, UX server and controllers do not follow the same release cadence). In this case, using RESTful client will have better UX experience, which will not display errors.

Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
.
Signed-off-by: Derek Wang <[email protected]>
.
Signed-off-by: Derek Wang <[email protected]>
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 18.18182% with 54 lines in your changes missing coverage. Please review.

Project coverage is 53.03%. Comparing base (6ecf01e) to head (2d7b0be).

Files Patch % Lines
server/apis/v1/handler.go 0.00% 30 Missing ⚠️
cmd/commands/server.go 50.00% 11 Missing ⚠️
server/routes/routes.go 0.00% 7 Missing ⚠️
server/cmd/server/start.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1826      +/-   ##
==========================================
+ Coverage   52.11%   53.03%   +0.92%     
==========================================
  Files         282      282              
  Lines       27286    27313      +27     
==========================================
+ Hits        14219    14485     +266     
+ Misses      12233    11984     -249     
- Partials      834      844      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Derek Wang <[email protected]>
@whynowy whynowy marked this pull request as ready for review July 15, 2024 02:27
@whynowy whynowy requested a review from vigith as a code owner July 15, 2024 02:27
Copy link
Member

@vigith vigith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice tests generation :)

@whynowy whynowy changed the title feat: enable resetful daemon client option for UX server feat: enable restful daemon client option for UX server Jul 15, 2024
@whynowy whynowy merged commit 251e84f into numaproj:main Jul 15, 2024
25 checks passed
@whynowy whynowy deleted the sdd branch July 15, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants