-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation is confusing on use of rad/degrees #50
Comments
On a related note (I don't think this really deserves a separate issue), the azimuth description in the |
Hi, sorry that flipped my intention. To the first comment: I partially disagree, I think it is still useful to write values in deg to describe the geometry conventions we are using. After all using radians in "spoken" language is weird. As a compromise, why not writing both: However, It would be appreciated if you could do propose and implement changes and create Pull-Request. To your second comment: This seems indeed wrong. If North is at 0 deg, West should be at 90 deg. However, I would argue that this is not strictly true. The magnetic field vector defined what is North. If you give pass a vector |
The homepage mentions that the default unit for angles is radians, however everywhere in the documentation and examples degrees are used. This is particularly confusing when looking at the documentation of the
__init__
function forcstrafo
, where the zenith and azimuth descriptions are in degrees. If this could be updated to use radians instead, it would help first time users like me tremendously 👍🏽The text was updated successfully, but these errors were encountered: