Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserService.MyInfo does not pass options to the request #9

Closed
nstratos opened this issue May 28, 2022 · 0 comments · Fixed by #13
Closed

UserService.MyInfo does not pass options to the request #9

nstratos opened this issue May 28, 2022 · 0 comments · Fixed by #13
Labels

Comments

@nstratos
Copy link
Owner

A lot of methods use the Client.list internally which handles options but UserService.MyInfo doesn't, so the options have to be passed "manually" but they are currently missing.

This became obvious because the only option that UserService.MyInfo supports is Fields which is not covered by a test and attempting to cover it makes no difference.

go test -covermode=count -coverprofile=count.out && go tool cover -html count.out

go-myanimelist-myinfo-no-options

@nstratos nstratos added the bug label May 28, 2022
@nstratos nstratos linked a pull request May 29, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant