-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make pyproject.toml
use PEP621 conventions to specify dependencies
#617
Comments
[tools.poetry.dependencies]
instead of a dependencies
key under [project]
. I think we should use PEP621-compliant configuration here regardless of whether we use Poetry or not.pyproject.toml
use PEP621 conventions to specify dependencies
@mfisher87 Hey I think poetry uses PEP-621 convention by default. isn't that the case or am I missing something? |
All of this config is poetry-specific: https://github.com/nsidc/earthaccess/blob/main/pyproject.toml#L37-L103 Although technically compliant with the spec by using poetry's aliases, it's more readable and portable to use the primary field names. Instead, we should be using the plan |
Maybe this isn't startable without switching away from Poetry? #614 (comment) |
So are we switching to setuptools? What do you think about this? |
I'm personally for this, but I think we need more input from the rest of the team. Our next hack day may be a good time to chat in real-time to make a decision. |
For example, we have
[tools.poetry.dependencies]
instead of adependencies
key under[project]
. I think we should use PEP621-compliant configuration here regardless of whether we use Poetry or not.Related: #374
The text was updated successfully, but these errors were encountered: