feat: Nx Move and Remove Project in Context Menu

[ZackDeRose]

Hey @Cammisuli - wanted to get your thoughts on this approach before going too far in.

You can see the code for yourself, but the idea here is:

• we'd add the move VsCode command
• we determine the appropriate move generator (given the URI [stubbed out for now - always does workspace:move])
• add additional optional parameters to allow this move generator to 'drill down' our existing API

I'm not a fan of the amount of "drilling" this approach takes, but I think it is the minimally invasive approach given our current state. (eventually it'd be nice to rework some of our APIs like we've discussed)

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e89a9e4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 3 targets

• nx run-many --all --parallel --target=build --max-parallel=3
• nx run-many --all --parallel --target=test --max-parallel=3
• nx run-many --all --parallel --target=lint --max-parallel=3

---

Sent with 💌 from NxCloud.

[Cammisuli]

I just took a quick look, and I see what you mean about the drilling down 😅 that WebView function is doing too much.

Either way, there's a few comments I have as well 😄

[Cammisuli]

I think it's better to use isAngularWorkspace here.

Suggested change

	"when": "!isNxWorkspace && config.nxConsole.enableGenerateFromContextMenu",
	"when": "isAngularWorkspace && config.nxConsole.enableGenerateFromContextMenu",

[Cammisuli]

We could probably find out the minimum version of Nx that introduced this generator and have that logic here. We have this function here that could be exported and used outside that project:

nx-console/libs/vscode/nx-workspace/src/lib/nx-version.ts

Line 7 in 16e3155

export function nxVersion(): number | null {

[ZackDeRose]

Oooh, hadn't considered that. Good point.

For versions younger than we had the move/remove generators, we should probably remove this option from the context menu, right?

[ZackDeRose]

Similar note: for when the user right-clicks on a node in the root, my solution would open the webview for the @nrwl/workspace:move generator; without a project set.

I think this is problematic, since we should be using the @nrwl/angular:move generator if the project is ends up being angular :\

[ZackDeRose]

@Cammisuli updates:

• Added logic for getting the correct generator (choose angular/move if installed, otherwise workspace/move) [comments added for future problems with this]
• Removed this context menu item for Angular CLI workspaces (move and remove only work for nx projects as I understand it)
• Added a version check to not add it for older nx versions.
• Left the "Nx Move...." option in the context menu even when not clicking on a project (this will open the generator webview WITHOUT a project set. I think this is probably the best solution, but I could see a valid argument for removing it unless you click on a project as well.)

Taking off the WIP, lmk if anything looks like it's missing!

[AgentEnder]

In regards to the @nrwl/angular:move vs @nrwl/workspace:move point, there's also the case of community plugin projects which may require their move generator. e.g., I'm about to add a move generator to nx-dotnet to handle updating .csproj file paths in addition to moving the files ( see nx-dotnet/nx-dotnet#406 ).

Do you think we could check for all installed plugins that have a generator called move, and prompt the user to choose between them?