fix: read and combine both schematics and generators #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nx Cloud ReportCI ran the following commands for commit 4f89b0d. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
Cammisuli
commented
Jun 28, 2021
| try { | ||
| Object.entries( | ||
| collectionJson.schematics || collectionJson.generators | ||
| Object.assign({}, collectionJson.schematics, collectionJson.generators) |
There was a problem hiding this comment.
I'd like to only do one or the other based on whether the workspace is an Angular workspace or a Nx one.
Cammisuli
commented
Jun 28, 2021
| @@ -211,7 +212,12 @@ export async function readSchematicOptions( | |||
| collectionPackageJson.json.generators, | |||
| dirname(collectionPackageJson.path) | |||
| ); | |||
| const schematics = collectionJson.json.schematics || collectionJson.json.generators; | |||
| const schematics = Object.assign( | |||
There was a problem hiding this comment.
Same thing here. We should check if the workspace is one or the other, and only read the appropriate schemas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Combines both schematics and generators schema's when reading schematics/generators