-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/test_edgesec.c
code-coverage is inconsistent
#435
Comments
It looks like this is still an issue, as of dd4f7a6. The issue seems to be that when GCC outputs the tracefile showing the code-coverage, it ignores this line, because it has no assembly associated with it: Line 79 in 39baecc
However, when Clang outputs their tracefile for code-coverage, it doesn't ignore this line. The following line of code (the branch above the Line 78 in 39baecc
I think if we test this branch in Clang too, this should fix this issue. |
Describe the bug
tests/test_edgesec.c
code-coverage is inconsistent.As an example, see #434 (comment).
This PR doesn't change anything in
tests/test_edgesec.c
, but somehowtests/test_edgesec.c
had a code-coverage change. This is consistently happening with our PRs, which is a bit annoying, since we sometimes get a false-positive ❌ saying that the code-coverage got worse, but it turns out it's justtests/test_edgesec.c
Expected behavior
tests/test_edgesec.c
code-coverage is consistent.Screenshots
Additional context
It looks like the issue is this line:
edgesec/tests/test_edgesec.c
Line 60 in 595fe95
I'm guessing maybe some of the CI compilers might be using a different version of
gcc
that uses different optimisation? I have a WIP commit that will test this branch, which should fix this issue, see 80e1ee7The text was updated successfully, but these errors were encountered: