-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email Address Internationalization #51
Comments
I remember that I once looke into this for implementing in Qsmtp. IIRC it was not that easy, so I would vote this for 1.09 or so, we have clearer things to do in 1.08. |
For reference, here's a copy of my analysis from the qmail list: I haven't noticed any problems with To reproduce the bug:
Temporarily wrapping qmail-there's The problem does not depend on whether the message is ASCII-only or UTF-8. My analysis: --- qmail-remote.c.orig 2017-07-30 18:24:37.000000000 +0000
+++ qmail-remote.c
@@ -253,6 +253,7 @@ void checkutf8message()
if (r == 0) break;
if (r == -1) temp_read();
+ if (ch == '\n' && !stralloc_append(&firstpart,"\r")) temp_nomem();
if (!stralloc_append(&firstpart,&ch)) temp_nomem();
if (ch == '\r') |
The patch has one more tiny problem. The variable
|
This is EH's version. https://www.fehcom.de/sqmail/doxygen/qmail-remote_8c_source.html |
I ended up testing both versions.
|
Awesome! At a glance, that function looks like it might lend itself to being unit tested. Given the short but already buggy history of |
That function is also a bit inefficient at a glance. For me it looks like if it is called multiple times, so I would say it should store it's result in a static variable and return early if that already has a value. |
The function is called just once, before the blast() function, and exits the moment it sees the UTF8 in the received header or the Date: header, whichever comes first. |
You are right, it's |
Russ Nelson has made very few updates to qmail.org (as of this writing, site's been down for a few weeks) in the last several years. One was pretty significant, though: Russ added Arnt Gulbrandsen's Email Address Internationalization (or EAI, or
SMTPUTF8
) patch to the very small "Recommended patches" section.Coming from Russ, this is a strong recommendation. Should we include EAI in 1.08? I played with this patch a year or two ago, have integrated it into pkgsrc qmail, and would suggest from foggy memory that this is not an easy "yes":
qmail-smtpd
s from accepting mail from an EAI-enabledqmail-remote
For reference:
The text was updated successfully, but these errors were encountered: