Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: norbajunior/machinist Loading
base: v0.4.0
Choose a base ref
...
head repository: norbajunior/machinist Loading
compare: v0.4.1
Choose a head ref
  • 5 commits
  • 4 files changed
  • 2 contributors

Commits on Apr 18, 2021

  1. Update README and docs

    norbajunior committed Apr 18, 2021
    Configuration menu
    Copy the full SHA
    e3942ea View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2021

  1. Update README.md

    norbajunior committed Oct 31, 2021
    Configuration menu
    Copy the full SHA
    ef358aa View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2021

  1. Update ci.yml

    norbajunior committed Nov 7, 2021
    Configuration menu
    Copy the full SHA
    64fca48 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2022

  1. Fix dialyzer warning of __set_new_state__ private function

    * When before_compile callback injects the two
    __set_new_state__ functions being one of them
    with a guard clause checking if the `new_state` is
    a function
    
    ```elixir
    defp __set_new_state__(resource, new_state) when is_function(new_state) do
      new_state.(resource)
    end
    
    defp __set_new_state__(_, new_state), do: new_state
    ```
    
    and the transitions defined in the module using machinist has all `to: state` definitions being a string, the `__set_new_state__/2 when is_function/1` will never be used. That’s why dialyzer reports the following warning:
    
    ```
    The guard test:
    
    is_function(_ :: <<_::64, _::size(8)>>)
    
    can never succeed.
    ```
    norbajunior committed Apr 9, 2022
    Configuration menu
    Copy the full SHA
    bcec565 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #7 from norbajunior/6-unexpected-behaviour

    Fix dialyzer warning of __set_new_state__ private function
    norbajunior committed Apr 9, 2022
    Configuration menu
    Copy the full SHA
    0fc457f View commit details
    Browse the repository at this point in the history
Loading