Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider renaming lifecycle events #29

Open
nombrekeff opened this issue Oct 21, 2023 · 0 comments
Open

Consider renaming lifecycle events #29

nombrekeff opened this issue Oct 21, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers question Further information is requested
Milestone
v1.0.0

Comments

@nombrekeff
Copy link
Owner

nombrekeff commented Oct 21, 2023 •
edited
Loading

Now they're called start, remove, beforeRemove. It might be a good idea to rename them to more common names like: mount, unmount, beforeUnmount, or something like that.
@nombrekeff nombrekeff added enhancement New feature or request good first issue Good for newcomers question Further information is requested labels Oct 21, 2023
@nombrekeff nombrekeff added this to the v1.0.0 milestone Oct 21, 2023
@nombrekeff nombrekeff linked a pull request Oct 27, 2023 that will close this issue
feat: added each and improved overall stability and cohesion #33
Merged
@nombrekeff nombrekeff removed a link to a pull request Oct 27, 2023
feat: added each and improved overall stability and cohesion #33
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers question Further information is requested
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@nombrekeff