Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bug : When the version of sklearn contains character sequences like "rc1, rc2", the Porter class cannot be created. #67

Open
earlsuke opened this issue Mar 25, 2020 · 1 comment

Comments

@earlsuke
Copy link

Hello, thanks for maintaining this library.
I found a bug related with sklearn's version string. When the version of sklearn contains character sequences like "rc1, rc2", the ValueError blocks to generate the Porter class. So, I fixed it and will send you a PR. Please, review it.

@benjaminhkaiser
Copy link

benjaminhkaiser commented Apr 29, 2020

To anyone else encountering this issue in the meantime (before a patch is pushed), just override the __version__ attribute of sklearn to drop the character sequences.

I'm using version 0.22.2.post1, so before I create a Porter, I include:

import sklearn   
sklearn.__version__ = "0.22.2"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants