Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec doesn't finalize connection on network error #948

Open
ronag opened this issue Aug 13, 2021 · 4 comments
Open

spec doesn't finalize connection on network error #948

ronag opened this issue Aug 13, 2021 · 4 comments

Comments

@ronag
Copy link
Member

ronag commented Aug 13, 2021

I've been reading through the spec a few times now and there seems to be missing a connection cleanup somewhere.

The problem is that whenever we replace response with a network error (example) that means that we no longer will read that response nor do we close the associated connection. Effectively leaking the connection.

Is this a bug in the spec or am I missing something? Maybe we need a "terminate" in fetch finale?

@ronag ronag added bug Something isn't working fetch labels Aug 13, 2021
@ronag
Copy link
Member Author

ronag commented Aug 13, 2021

@szmarczak @annevk

@ronag ronag added this to the 4.0 milestone Aug 13, 2021
@ronag
Copy link
Member Author

ronag commented Aug 13, 2021

42b67e1

@ronag
Copy link
Member Author

ronag commented Aug 13, 2021

Or maybe the spec assumes that GC should handle this? #950

@ronag ronag modified the milestones: 4.0, stable fetch Aug 13, 2021
@szmarczak
Copy link
Member

Indeed. I believe the connection should be terminated.

@ronag ronag added the spec label Aug 17, 2021
@ronag ronag removed the bug Something isn't working label Nov 11, 2021
@ronag ronag removed this from the stable fetch milestone Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants