Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Union the translations for "简体中文" and "繁体中文". #3770

Merged
merged 2 commits into from
Mar 30, 2021
Merged

Union the translations for "简体中文" and "繁体中文". #3770

merged 2 commits into from
Mar 30, 2021

Conversation

SEWeiTung
Copy link
Contributor

@SEWeiTung SEWeiTung commented Mar 27, 2021 •
edited
Loading

Union the translations for "简体中文" and "繁体中文".

@SEWeiTung
Copy link
Contributor Author

Ping @nodejs/nodejs-cn, @nodejs/nodejs-tw

@SEWeiTung SEWeiTung changed the title fixture for translation '繁体中文' zh-cn, zh-TW: fixture for translation '繁体中文' Mar 28, 2021
@dca dca self-requested a review March 29, 2021 02:16
dca
dca previously approved these changes Mar 29, 2021
View reviewed changes
@dca dca self-requested a review March 29, 2021 02:28
wazho
wazho reviewed Mar 29, 2021
View reviewed changes
locale/zh-cn/site.json Outdated Show resolved Hide resolved
locale/zh-tw/site.json Outdated Show resolved Hide resolved
willin
willin approved these changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@willin willin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Maledong and others added 2 commits March 30, 2021 16:29
fixture for translation '繁体中文'
781d459 
We tend to call it as 'Chinese Traditional' instead of 'Traditional
Chinese'.
@SEWeiTung
Merge branch 'master' into langCheck
fa66661
@SEWeiTung SEWeiTung changed the title zh-cn, zh-TW: fixture for translation '繁体中文' Union the translations for "简体中文" and "繁体中文". Mar 30, 2021
@SEWeiTung
Copy link
Contributor Author

After looking for Oxford Dictionary online, it seems "Chinese Simplified" should be "Chinese (Simplified)", and the correct should be "Simplified Chinese" fitting for "简体中文". So is for the "繁体中文".

Thanks for @dca and @willin

@SEWeiTung SEWeiTung merged commit 8445365 into nodejs:master Mar 30, 2021
@SEWeiTung SEWeiTung deleted the langCheck branch March 30, 2021 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willin willin willin approved these changes

@wazho wazho wazho left review comments

@dca dca Awaiting requested review from dca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SEWeiTung @dca @willin @wazho