src: use std::unique_ptr for STACK_OF(X509) #19087

bnoordhuis · 2018-03-02T16:01:58Z

Daniel indicated he was short on time and I figured we could go above and beyond the suggestion from #17372 (comment).

PR-URL: nodejs#17372 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>

Convert manual memory management of STACK_OF(X509) instances to std::unique_ptr with a custom deleter. Note the tasteful application of std::move() to indicate a function that consumes its argument.

BridgeAR · 2018-03-02T19:14:12Z

CI https://ci.nodejs.org/job/node-test-pull-request/13457/

danbev · 2018-03-06T11:35:13Z

node-test-commit failures looks unrelated

console output:

Makefile:90: recipe for target 'node' failed
make[1]: *** [node] Error 2
Makefile:464: recipe for target 'build-ci' failed
make: *** [build-ci] Error 2
Build step 'Conditional steps (multiple)' marked build as failure
Run condition [Always] enabling perform for step [[]]
TAP Reports Processing: START
Looking for TAP results report in workspace using pattern: *.tap
Did not find any matching files. Setting build result to FAILURE.
Checking ^not ok
Jenkins Text Finder: File set '*.tap' is empty
Notifying upstream projects of job completion
Finished: FAILURE

node-test-commit-linuxone failure looks unrelated

console output:

not ok 864 parallel/test-http2-https-fallback
  ---
  duration_ms: 0.263
  severity: fail
  stack: |-
    (node:49136) ExperimentalWarning: The http2 module is an experimental API.
    assert.js:243
        throw err;
        ^
    
    AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
    
      assert.ok(/Unknown ALPN Protocol, expected `h2` to be available/.test(text))
    
        at TLSSocket.tls.setEncoding.on.on.common.mustCall (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/parallel/test-http2-https-fallback.js:143:9)
        at TLSSocket.<anonymous> (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/common/index.js:467:15)
        at TLSSocket.emit (events.js:136:15)
        at endReadableNT (_stream_readable.js:1021:12)
        at process._tickCallback (internal/process/next_tick.js:115:19)

node-test-commit-windows-fanned failures looks unrelated

console output:

c:\workspace\node-test-binary-windows>git reset --hard   || true
HEAD is now at 1cef52e814 added binaries

c:\workspace\node-test-binary-windows>mv ../test.tap test.tap   || true
mv: cannot stat '../test.tap': No such file or directory

c:\workspace\node-test-binary-windows>mv ../cctest.tap cctest.tap   || true
mv: cannot stat '../cctest.tap': No such file or directory

c:\workspace\node-test-binary-windows>exit /b 1 
Build step 'Execute Windows batch command' marked build as failure
TAP Reports Processing: START
Looking for TAP results report in workspace using pattern: *.tap
Did not find any matching files. Setting build result to FAILURE.
Checking ^not ok
Jenkins Text Finder: File set '*.tap' is empty
Notifying upstream projects of job completion
Finished: FAILURE

PR-URL: #19087 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>

Convert manual memory management of STACK_OF(X509) instances to std::unique_ptr with a custom deleter. Note the tasteful application of std::move() to indicate a function that consumes its argument. PR-URL: #19087 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>

danbev · 2018-03-06T11:47:32Z

Landed as 0c7e7d4, and e46d0bc. Thanks for all the help/reviews!

PR-URL: #19087 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>

Convert manual memory management of STACK_OF(X509) instances to std::unique_ptr with a custom deleter. Note the tasteful application of std::move() to indicate a function that consumes its argument. PR-URL: #19087 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>

PR-URL: #19087 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>

Convert manual memory management of STACK_OF(X509) instances to std::unique_ptr with a custom deleter. Note the tasteful application of std::move() to indicate a function that consumes its argument. PR-URL: #19087 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>

PR-URL: #19087 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>

Convert manual memory management of STACK_OF(X509) instances to std::unique_ptr with a custom deleter. Note the tasteful application of std::move() to indicate a function that consumes its argument. PR-URL: #19087 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>

PR-URL: #19087 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>

Convert manual memory management of STACK_OF(X509) instances to std::unique_ptr with a custom deleter. Note the tasteful application of std::move() to indicate a function that consumes its argument. PR-URL: #19087 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>

PR-URL: #19087 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>

Convert manual memory management of STACK_OF(X509) instances to std::unique_ptr with a custom deleter. Note the tasteful application of std::move() to indicate a function that consumes its argument. PR-URL: #19087 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>

PR-URL: nodejs#19087 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>

Convert manual memory management of STACK_OF(X509) instances to std::unique_ptr with a custom deleter. Note the tasteful application of std::move() to indicate a function that consumes its argument. PR-URL: nodejs#19087 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>

jasnell · 2018-08-17T22:58:12Z

Should this be backported to 8.x? If so, we need a separate backport PR.

danbev and others added 2 commits March 2, 2018 16:57

src: refactor GetPeerCertificate

a40bd63

PR-URL: nodejs#17372 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>

src: use std::unique_ptr for STACK_OF(X509)

543974d

Convert manual memory management of STACK_OF(X509) instances to std::unique_ptr with a custom deleter. Note the tasteful application of std::move() to indicate a function that consumes its argument.

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Mar 2, 2018

bnoordhuis mentioned this pull request Mar 2, 2018

src: refactor GetPeerCertificate #17372

Closed

2 tasks

jasnell approved these changes Mar 2, 2018

View reviewed changes

BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 2, 2018

addaleax approved these changes Mar 2, 2018

View reviewed changes

danbev approved these changes Mar 3, 2018

View reviewed changes

danbev added a commit that referenced this pull request Mar 6, 2018

src: refactor GetPeerCertificate

e46d0bc

PR-URL: #19087 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>

danbev closed this Mar 6, 2018

MylesBorins pushed a commit that referenced this pull request Mar 6, 2018

src: refactor GetPeerCertificate

3a7e722

PR-URL: #19087 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>

MylesBorins mentioned this pull request Mar 6, 2018

v9.8.0 proposal #19181

Merged

MylesBorins pushed a commit that referenced this pull request Mar 6, 2018

src: refactor GetPeerCertificate

2184744

PR-URL: #19087 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>

MylesBorins pushed a commit that referenced this pull request Mar 6, 2018

src: refactor GetPeerCertificate

c1b3a15

PR-URL: #19087 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>

MylesBorins pushed a commit that referenced this pull request Mar 6, 2018

src: refactor GetPeerCertificate

d6153e9

PR-URL: #19087 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>

MylesBorins pushed a commit that referenced this pull request Mar 7, 2018

src: refactor GetPeerCertificate

f10470c

PR-URL: #19087 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>

jasnell added the backport-requested-v8.x label Aug 17, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

src: use std::unique_ptr for STACK_OF(X509) #19087

src: use std::unique_ptr for STACK_OF(X509) #19087

bnoordhuis commented Mar 2, 2018

BridgeAR commented Mar 2, 2018

danbev commented Mar 6, 2018

danbev commented Mar 6, 2018

jasnell commented Aug 17, 2018

src: use std::unique_ptr for STACK_OF(X509) #19087

src: use std::unique_ptr for STACK_OF(X509) #19087

Conversation

bnoordhuis commented Mar 2, 2018

BridgeAR commented Mar 2, 2018

danbev commented Mar 6, 2018

danbev commented Mar 6, 2018

jasnell commented Aug 17, 2018