Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out C++ wrappers to target js-native-api #399

Closed
bghgary opened this issue Nov 27, 2018 · 3 comments
Closed

Factor out C++ wrappers to target js-native-api #399

bghgary opened this issue Nov 27, 2018 · 3 comments
Labels

Comments

@bghgary
Copy link

bghgary commented Nov 27, 2018

Following the work from nodejs/abi-stable-node#354, it would be ideal if the code in the C++ wrappers can also be factored out.

CC @gabrielschulhof @mhdawson

@bghgary
Copy link
Author

bghgary commented Oct 22, 2019

Hi @gabrielschulhof @mhdawson,

It's been a while, but we are finally ready to push some changes. @syntheticmagus has created a draft PR (#569) with some changes that will suit our needs. Do you mind taking a look? Thanks.

@github-actions
Copy link
Contributor

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label Dec 18, 2020
@mhdawson
Copy link
Member

The referenced PR was closing so I think this issue can be closed as well until those involved have time to move it forward again. Please let us know if you think that was not the right thing to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants