Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add needs-ci label for PRs made modifying tools/ in core repo #308

Open
DerekNonGeneric opened this issue Dec 8, 2021 · 2 comments
Open

Comments

@DerekNonGeneric
Copy link
Contributor

DerekNonGeneric commented Dec 8, 2021

This was requested by @BridgeAR in nodejs/node#41102, but had not yet been fully resolved by the PR that closed that issue. I have not contributed to this repo in a while, but I may be able to handle it here if there is any interest in getting this taken care of here.

/cc @Trott @aduh95

@DerekNonGeneric DerekNonGeneric changed the title add request-ci label for PRs made modifying tools/ in core repo add needs-ci label for PRs made modifying tools/ in core repo Dec 8, 2021
@DerekNonGeneric
Copy link
Contributor Author

I will have to put this off until a fully-green CI can be made achieveable even once.

The master branch appears to be currently making good progress towards that goal.

@phillipj
Copy link
Member

phillipj commented Dec 12, 2021

Hi @DerekNonGeneric,

automagic PR labelling was indeed done by this project for years. That was changed earlier this year tho, by moving that responsibility into a GitHub Action instead: nodejs/node-pr-labeler.

Main goal by doing so was to move the logic related to file path -> label into the project using the GitHub Action, instead of inside the GitHub Action project (or github-bot). For nodejs/node that configuration lives in: nodejs/node/.github/label-pr-config.yml.

Bottom line: I think what you're asking will be solved by changing the above configuration file inside nodejs/node.

Let me know if you need some help getting there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants