Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing 'checkboxes' in github templates #122

Open
jbergstroem opened this issue Feb 2, 2017 · 2 comments
Open

Replacing 'checkboxes' in github templates #122

jbergstroem opened this issue Feb 2, 2017 · 2 comments

Comments

@jbergstroem
Copy link
Member

It would be awesome if we could move towards replacing our checkboxes in PR's by looking at the commit and providing that feedback differently.

We already do some similar stuff by tagging. A few of the things mentioned in this issue is obviously out of scope - but I felt that describing my perceived future would make it easier to understand the changes/features I'm suggesting.

I guess the discussion about checkboxes is tangential with user feedback in general, but by looking github interprets checkboxes/messages (poor formatting as part of timelines, adds progress to issue listings, etc) I feel that what we want to identify might as well work a bit differently. We could for instance:

  • spawn a bot that identifies that changes are made/introduced but lacks a test
  • spawn a benchmark if it touches related benchmarks
  • run remarkrc on documentation if it is updated

Finally, we can run the commit message validator once we've deemed it 'ready' to merge (commit message metadata, properly rebased, all other tests merge).

I guess the final (and future) step is the long awaited auto-merge; which also could grow the functionality of adding PR/Reviewed-by references.

..all of above could be reported through the testing section. I'm personally not a big fan of abusing comments for bot input/output since it can potentially ping a lot of people.

@targos
Copy link
Member

targos commented Feb 2, 2017

+1 for using the testing section for this feedback. Is there a limit on the number of checks that you can add in a PR?

@jbergstroem
Copy link
Member Author

@targos I recall a number large enough to not really care. In time, we'll likely fold all the platform tests into one output as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants