Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal - Cleanup the modules failing often #955

Closed
RafaelGSS opened this issue Jul 4, 2023 · 9 comments
Closed

Proposal - Cleanup the modules failing often #955

RafaelGSS opened this issue Jul 4, 2023 · 9 comments

Comments

@RafaelGSS
Copy link
Member

RafaelGSS commented Jul 4, 2023

When performing a release, we usually compare the citgm run against the previous CI. This, however, does hide modules that are failing often. Instead of comparing 100 failures with 101 failures and proceeding with the release, we should lower this number the much as we can, otherwise, the citgm will become meanless.

I think we should:

  • When the package fails frequently, ping the module author.
  • Drop the package from lookup.json when no response from the "maintainer"

This should help the releasers a lot (plus reducing the citgm time).

cc: @nodejs/releasers

@targos
Copy link
Member

targos commented Jul 4, 2023

Isn't it the purpose of the "maintainers" field?

@RafaelGSS
Copy link
Member Author

Oh, yeah. My bad. Let me adjust the proposal to cover the second part only.

@RafaelGSS RafaelGSS changed the title Proposal - add author field to each citgm package Proposal - Cleanup the modules failing often Jul 4, 2023
@bengl
Copy link
Member

bengl commented Jul 5, 2023

When the package fails frequently, ping the module author.

If this is going to block releases, it may be worth collecting alternative contact information, since GitHub notifications can be overwhelming (and thus ignored or dealt with in delayed batches) by some folks.

@mhdawson
Copy link
Member

+1 to the suggestion.

@RafaelGSS
Copy link
Member Author

Adding Release-agenda to mention it in the next meeting so we can move it forward

@joyeecheung
Copy link
Member

joyeecheung commented Sep 7, 2023

Since the CITGM has been red for years, maybe a better approach would be just starting from a clean slate, and gradually add modules back while strictly keeping it green. A red CI in the normally green CI is much more noticable, and I feel the approach of trying to remove modules until it's green had not been working well for a long time until this day...

@RafaelGSS
Copy link
Member Author

Ref #959

@targos
Copy link
Member

targos commented Nov 16, 2023

We discussed this in the WG meeting today. Suggestion is that someone opens a pull request documenting the procedure. Once the PR is accepted and merged, we can close this.

@RafaelGSS
Copy link
Member Author

I'm closing it as concluded as the first step has been concluded #958 #929 #1035

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants