-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semver Minor Tracking #298
Comments
@nodejs/lts quick ping, do people have time to meet and discuss this at all next week? |
Next week SGTM |
1 similar comment
Next week SGTM |
I've created two gists I'm quite sick and may not have the ability to review this in a timely fashion @nodejs/release @nodejs/lts @nodejs/collaborators @nodejs/tsc would people be able to review these lists and please request the semver minor commits you would like to see on the next LTS release on v6.x and v8.x |
Let me know what I need to do to get nodejs/node#17365 into v6.x, or if it is already ready to be applied. |
I would like to have: nodejs/node@c5c4a534d1 backported. (edited by @addaleax: made commits clickable) |
Another quick ping to @nodejs/collaborators to review these lists. I really would appreciate any work y'all can do. |
I would like to see nodejs/node@8d90db5120 and the async_hooks commits land in v8.x |
@evanlucas Indeed, I tried adding |
@AndreasMadsen would you be able to do a batch backport? |
@MylesBorins I can definitely try. |
@AndreasMadsen for async_hooks were you talking about 8.x or 6.x? |
@mcollina here is a list of streams based commits to review (will be updated) |
We would like to land nodejs/node#13467 but it requires manual backport of the documentation. Would someone be interested in taking that on? |
@Trott would you want to backport nodejs/node#14910 to v6.x? nbd if you don't have time |
@cjihrig would you want to backport nodejs/node#15034 to v6.x? |
@nodejs/crypto would anyone want to backport nodejs/node#15206? |
@danbev could you backport nodejs/node#16790 |
@maclover7 could you backport nodejs/node#16386 ? |
async_hooks should not land in 6.x. I have already added |
I think this is the list of
|
If it'd make more sense for @yhwang to backport that one separately that's fine by me. |
@gibfahn It wasn't too big of an issue. I have already backported the first 7 commits. I hope to have it all done within the next 6 hours. I would appreciate if we can put |
I was missing two commits there was under the
|
@MylesBorins @gibfahn @evanlucas I have finished the |
nodejs/node#17470 should also be included in the v6.x backport of WHATWG URL parser as it fixes a critical memory leak. It had not been landed yet at the time of my backport PR, and I neglected to add it in after it had by mistake. |
@TimothyGu lands cleanly on v8.x with green tests. Doesn't work on v6.x as nodejs/node@9236dfe utilizes std::move. Requesting backport |
We have a month with 5 Tuesdays, this means we can do a Semver Minor release!!!
I'm thinking it makes sense for both 6.x and 8.x.
Will follow up with a list of potential commits soon (unless someone else wants to do it first :D)
The text was updated successfully, but these errors were encountered: