{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":624356575,"defaultBranch":"main","name":"nushell","ownerLogin":"noble-varghese","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2023-04-06T09:36:10.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/109506617?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1680773777.4558358","currentOid":""},"activityList":{"items":[{"before":"7413ef28243d7586037b8b0b9133e6e7c7d44255","after":"2a484a3e7e169e699766e1883ccb1286b2383212","ref":"refs/heads/main","pushedAt":"2023-05-10T06:12:35.543Z","pushType":"push","commitsCount":67,"pusher":{"login":"noble-varghese","name":"Noble Varghese","path":"/noble-varghese","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/109506617?s=80&v=4"},"commit":{"message":"fix: use `buffer.len()` instead of `cursor_pos`, so the `.expect()` isn't useless (#9053)\n\n# Description\r\nUse `buffer.len()` instead of `cursor_pos`, so the `.expect()` isn't\r\nuseless.\r\n\r\n# User-Facing Changes\r\n\r\n# Tests + Formatting\r\n\r\n# After Submitting","shortMessageHtmlLink":"fix: use buffer.len() instead of cursor_pos, so the .expect() i…"}},{"before":"8ee52b6ee1cebfbb265d68efcffed97254a7c252","after":"7413ef28243d7586037b8b0b9133e6e7c7d44255","ref":"refs/heads/main","pushedAt":"2023-04-23T18:31:35.883Z","pushType":"push","commitsCount":53,"pusher":{"login":"noble-varghese","name":"Noble Varghese","path":"/noble-varghese","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/109506617?s=80&v=4"},"commit":{"message":"Tweak run-external signature so command must be a string (#8971)\n\nTiny fix: clarify in `run-external`'s signature that the external\r\ncommand must be a string.\r\n\r\n### Before\r\n```\r\nSignatures:\r\n | run-external -> \r\n\r\nParameters:\r\n command : external command to run\r\n ...args : arguments for external command\r\n```\r\n\r\n### After\r\n```\r\nSignatures:\r\n | run-external -> \r\n\r\nParameters:\r\n command : external command to run\r\n ...args : arguments for external command\r\n```\r\n\r\n\r\n### Notes\r\n\r\nI was hoping to change more `any`s to more specific types, but alas I\r\nthink we can only change `command` right now. The input can be any type\r\nand it gets rendered to a string before being passed to the external.\r\nThe args can be any value type and they get converted to strings. The\r\noutput can be either binary or a string.","shortMessageHtmlLink":"Tweak run-external signature so command must be a string (nushell#8971)"}},{"before":"eb4d19fb9cc1b997f297662b1ada2f3069220927","after":"8ee52b6ee1cebfbb265d68efcffed97254a7c252","ref":"refs/heads/main","pushedAt":"2023-04-11T18:56:16.781Z","pushType":"push","commitsCount":2,"pusher":{"login":"noble-varghese","name":"Noble Varghese","path":"/noble-varghese","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/109506617?s=80&v=4"},"commit":{"message":"Relax the closure syntax, highlight differently (#8846)\n\n# Description\r\n\r\nThis relaxes the closure syntax so that `||` is no longer required. This\r\nallows for `ls | each { $in.name }` for example.\r\n\r\nI've gone ahead and changed the syntax highlighting so that blocks and\r\nclosures are distinct for now.\r\n\r\n# User-Facing Changes\r\n\r\nRemoves `||` requirement for closures.\r\n\r\n# Tests + Formatting\r\n\r\nDon't forget to add tests that cover your changes.\r\n\r\nMake sure you've run and fixed any issues with these commands:\r\n\r\n- `cargo fmt --all -- --check` to check standard code formatting (`cargo\r\nfmt --all` applies these changes)\r\n- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A\r\nclippy::needless_collect` to check that you're using the standard code\r\nstyle\r\n- `cargo test --workspace` to check that all tests pass\r\n- `cargo run -- crates/nu-std/tests/run.nu` to run the tests for the\r\nstandard library\r\n\r\n> **Note**\r\n> from `nushell` you can also use the `toolkit` as follows\r\n> ```bash\r\n> use toolkit.nu # or use an `env_change` hook to activate it\r\nautomatically\r\n> toolkit check pr\r\n> ```\r\n\r\n# After Submitting\r\n\r\nIf your PR had any user-facing changes, update [the\r\ndocumentation](https://github.com/nushell/nushell.github.io) after the\r\nPR is merged, if necessary. This will help us keep the docs up to date.","shortMessageHtmlLink":"Relax the closure syntax, highlight differently (nushell#8846)"}},{"before":"f2b977b9c59931ad2b5e55174e63ebbec50b8cbe","after":"eb4d19fb9cc1b997f297662b1ada2f3069220927","ref":"refs/heads/main","pushedAt":"2023-04-11T13:03:02.285Z","pushType":"push","commitsCount":17,"pusher":{"login":"noble-varghese","name":"Noble Varghese","path":"/noble-varghese","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/109506617?s=80&v=4"},"commit":{"message":"Parser panic for signature with multibyte char for short flag #8821 (#8849)\n\nHey I'm a developer and I'm still new to nushell and rust but I would\r\nlike to learn more about both. This is my first PR for this project.\r\n\r\nThe intent of my change is to allow to use multibyte utf-8 characters in\r\ncommands short flags.","shortMessageHtmlLink":"Parser panic for signature with multibyte char for short flag nushell…"}},{"before":"bcdb9bf5b4dafad570260ecdaeabf4edbbef363c","after":"f2b977b9c59931ad2b5e55174e63ebbec50b8cbe","ref":"refs/heads/main","pushedAt":"2023-04-08T06:21:11.756Z","pushType":"push","commitsCount":24,"pusher":{"login":"noble-varghese","name":"Noble Varghese","path":"/noble-varghese","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/109506617?s=80&v=4"},"commit":{"message":"improve operation mismatch errors (#8800)\n\n# Description\r\n\r\nThis improves the operation mismatch error in a few ways:\r\n\r\n* We now detect if the left-hand side of the operation is at fault, and\r\nshow a simpler error/error message if it is\r\n* Removed the unhelpful hint\r\n* Updated the error text to make it clear what types are causing the\r\nissue\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n# User-Facing Changes\r\n\r\nError texts and spans will change\r\n\r\n# Tests + Formatting\r\n\r\nDon't forget to add tests that cover your changes.\r\n\r\nMake sure you've run and fixed any issues with these commands:\r\n\r\n- `cargo fmt --all -- --check` to check standard code formatting (`cargo\r\nfmt --all` applies these changes)\r\n- `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A\r\nclippy::needless_collect` to check that you're using the standard code\r\nstyle\r\n- `cargo test --workspace` to check that all tests pass\r\n- `cargo run -- crates/nu-utils/standard_library/tests.nu` to run the\r\ntests for the standard library\r\n\r\n> **Note**\r\n> from `nushell` you can also use the `toolkit` as follows\r\n> ```bash\r\n> use toolkit.nu # or use an `env_change` hook to activate it\r\nautomatically\r\n> toolkit check pr\r\n> ```\r\n\r\n# After Submitting\r\n\r\nIf your PR had any user-facing changes, update [the\r\ndocumentation](https://github.com/nushell/nushell.github.io) after the\r\nPR is merged, if necessary. This will help us keep the docs up to date.","shortMessageHtmlLink":"improve operation mismatch errors (nushell#8800)"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAADKZyMZgA","startCursor":null,"endCursor":null}},"title":"Activity · noble-varghese/nushell"}