Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specialized SSL connection functions (STARTTLS) can't cope with Nsock's SSLv2 reconnection strategy #378

Open
dmiller-nmap opened this issue May 13, 2016 · 1 comment

Comments

@dmiller-nmap
Copy link

If OpenSSL supports SSLv2, then Nsock tries to use a SSLv2-compatible handshake first, and if that fails, it closes the socket, reopens it, and restarts the handshake with SSL_OP_NO_SSLv2. This breaks all the scripts that rely on sslcert.lua's specialized SSL connection functions (a.k.a. STARTTLS), since in those cases, the specialized setup handshake has to happen for each TCP connection opened.

A possible fix for this would be to remove this fallback from Nsock and give the application (Nmap or NSE) finer-grained control over SSL options. It would be more of a pain and mean we'd be writing this fallback code in multiple places, but otherwise I don't see how to handle it for the STARTTLS case.

@nnposter
Copy link

nnposter commented Jan 9, 2020

@dmiller-nmap Is this effectively addressed by your r37851 (81ceee4) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants