Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vhosts-default.lst too big? #2049

Open
nnposter opened this issue May 20, 2020 · 1 comment
Open

vhosts-default.lst too big? #2049

nnposter opened this issue May 20, 2020 · 1 comment

Comments

@nnposter
Copy link

Commit r32488 (bb77ad2) has added numerous entries into nselib/data/vhosts-default.lst, increasing its size five-fold.

Considering that the same additions were not made to nselib/data/vhosts-full.lst, it should be reviewed whether the update failed to account for existence of the second list and whether the bulk of these entries should not have been added into the full list instead, keeping the default list small for performance reasons. See commit 1441aea for additional information about the two lists.

One possible rule of thumb for the default list could be whether the entry likely represents a web interface. As an example, cms might be a good entry for the default list but dns2 might not.

P.S. All the missing entries have been added to the full list in r37929 (0d966d9).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants
@nnposter and others