FIXME and TODO comments in source files

[dmiller-nmap]

These will never be completely eliminated, but this should serve as a reminder to whittle away at them. Current count: 198

Target.h:178: public: /* For now ... TODO: a lot of the data members should be made private */
docs/style/lua-format.lua:119:  --filler_comment = (V "space" - P "\n")^0 * INDENT * (V "one_line_comment" - V "multi_line_comment"); -- * C "\n"^-1; -- FIXME highlighted after INDENT
libnetutil/ARPHeader.h:205:/* TODO @todo: getTargetIP() and getSenderIP() should  either 
libnetutil/DestOptsHeader.cc:145:  // TODO: @todo : Implement this
libnetutil/FragmentHeader.cc:210:  // TODO: @todo : Implement this
libnetutil/HopByHopHeader.cc:381:  // TODO: @todo : Implement this
libnetutil/ICMPv4Header.cc:213:      /* WARNING: TODO: @todo This does not work for those messages whose
libnetutil/ICMPv4Header.cc:301:        /* TODO: print TTL and domain names in replies */
libnetutil/IPv4Header.cc:375:  /* TODO: Should we check here that i<8192 ? */
libnetutil/IPv4Header.cc:384:  /* TODO: Should we check here that i<8192 ? */
libnetutil/PacketParser.cc:671:/* TODO: remove */
libnetutil/PacketParser.cc:1080:          /* TODO @todo: getTargetIP() and getSenderIP() should 
libnetutil/PacketParser.cc:1539:               * yet, so we don't match it. TODO: Implement support for MLDv2 */
libnetutil/PacketParser.cc:1580:               * TODO: Implement these ICMPv6 types. */
libnetutil/PacketParser.h:184:    static int dummy_print_packet_type(const u8 *pkt, size_t pktlen, bool eth_included); /* TODO: remove */
libnetutil/PacketParser.h:185:    static int dummy_print_packet(const u8 *pkt, size_t pktlen, bool eth_included); /* TODO: remove */
libnetutil/RoutingHeader.cc:311:  // TODO: @todo : Implement this
libnetutil/TCPHeader.cc:459:/* TODO: Test this method. It may not work becuasse th_off is supposed to
libnetutil/netutil.cc:2023:/* TODO: Needs refactoring */
libnetutil/netutil.cc:2042:/* TODO: Needs refactoring */
libnetutil/netutil.cc:2635:    /* TODO: See if we can segfault if we receive a fragmented packet whose IP packet does not say a thing about fragmentation */
libnetutil/netutil.cc:2773:        /* TODO: We should actually check the datagram checksum to
libnetutil/netutil.cc:4193:    // FIXME: I eventually need to figure out why Windows head.ts time is sometimes BEFORE the time I
libnetutil/netutil.cc:4262:    /* TODO: First parameter "2" is a hardcoded value for Nmap's PacketTrace::RECV. */
libnetutil/netutil.cc:4315:    /* TODO: First parameter "2" is a hardcoded value for Nmap's PacketTrace::RECV. */
libnetutil/netutil.cc:4406:        /* TODO: First parameter "1" is a hardcoded value for Nmap's PacketTrace::SENT*/
libnetutil/netutil.cc:4503:        /* TODO: First parameter "1" is a hardcoded value for Nmap's PacketTrace::SENT*/
ncat/ncat_connect.c:807:    /* TODO just two bytes for now, need to read more for bind */
ncat/ncat_core.c:483:    /* FIXME: needs to be audited closer */
ncat/ncat_listen.c:333:         * FIXME: optimize this loop to look only at the fds in the fd list,
nmap_dns.cc:173:https:// TODO:
nmap_dns.cc:512:            // FIXME: Find a good compromise
nmap_winconfig.h:136:#define NMAPDATADIR "c:\\nmap" /* FIXME: I really need to make this dynamic */
nping/ArgParser.cc:213:  /* TODO: Add relevant flags for different ICMP options */
nping/ArgParser.cc:647:    /* TODO: Add more relevant flags for different ICMP options */
nping/ArgParser.cc:777:        /* TODO: At some point we may want to let users specify TTLs like "linux",
nping/ArgParser.cc:1456:/* TODO: They are not implemented but there are more types in
nping/Crypto.cc:272:    // @todo TODO finish this.
nping/EchoHeader.cc:298:  u32 t=(u32)time(NULL);  /* TODO: Make sure this does not cause problems */
nping/NpingOps.cc:2295:  /* TODO: Check this because although nmap does exactly the same, it has a this->have_pcap that may affect to this */
nping/NpingOps.h:289:    struct in_addr icmp_redir_addr; /* ICMP Redirect Address */ /* ##TODO## Turn this into an IPAddress object */
nping/NpingTarget.cc:927:        gettimeofday(&this->sentprobes[i].sent, NULL); /* overwrite previous value? TODO: think about this */
nping/NpingTarget.cc:985:        gettimeofday(&this->sentprobes[i].sent, NULL); /* overwrite previous value? TODO: think about this */
nping/NpingTargets.h:128:/* TODO: Needs to be changed if we move TargetGroup to another source file */
nping/NpingTargets.h:170:    /* TODO: Make private */
nping/ProbeMode.cc:316:                    /* TODO: At some point we want to support David's custom UDP payloads here*/
nping/ProbeMode.cc:1138:          /* TODO: What do we do here if user specified a non standard type? */
nping/ProbeMode.cc:1143:    c4.setSum(); /* TODO: Do we want to implement --badsum-icmp? */
nping/ProbeMode.cc:1783:                /* TODO: find target and call setProbeRecvARP() */
nping/common_modified.cc:389:/* TODO: WARNING: This functions has been modified for portability. Check
nping/nping-dev/ipv6fp.py:3125:        #       be considered. @todo TODO
nping/nping-dev/ipv6fp.py:3144:        #       be considered. @todo TODO
nping/nping.cc:279:  * TODO: Many of the things done in this function may not be safe due to
nping/utils.cc:275: * TODO: Check if this function is endian-safe. 
nping/utils_net.cc:1204:         * TODO: Should we check here if #ifdef LINUX and set the port to
nping/utils_net.cc:1316:    else /* Extension headers not supported, return NULL TODO: support it? */
nping/utils_net.cc:1346:    else /* Extension headers not supported, return NULL TODO: support it? */
nping/utils_net.cc:1544:  /* TODO: Do we fatal() or should we just error and return OP_FAILURE? */
nping/utils_net.cc:1565:     * TODO: Can interfaces with format eth0:1 appear on /proc/net/if_inet6?
nping/utils_net.cc:1738:  /* TODO: Do we fatal() or should we just error and return OP_FAILURE? */
nping/utils_net.cc:1756:     * TODO: Can interfaces with format eth0:1 appear on /proc/net/ipv6_route?
nping/utils_net.cc:1878:    /* TODO: Check the endianness stuff here is implemented right.
nselib/afp.lua:2048:      -- TODO: This really needs to be addressed someway
nselib/bitcoin.lua:249:      -- TODO: Alert decoding goes here
nselib/data/http-default-accounts-fingerprints.lua:20:-- TODO: Update the functionality of <code>target_check</code> to differentiate
nselib/data/http-fingerprints.lua:4633:        -- TODO: this only works for Meterpreter payloads. Find a more generic means?
nselib/data/packetdecoders.lua:177:            -- TODO: add more decoding of types here ...
nselib/data/packetdecoders.lua:181:        -- TODO: add code for dups check
nselib/data/psexec/backdoor.lua:15:-- TODO: allow the user to specify parameters
nselib/dhcp6.lua:356:      -- TODO: we don't cover self.options here, we should probably add that
nselib/dhcp6.lua:517:-- TODO: These functions could eventually be moved to a method in its
nselib/dnsbl.lua:378:          -- TODO Should we return failure in the result?
nselib/eigrp.lua:156:        -- TODO
nselib/eigrp.lua:160:        -- TODO
nselib/eigrp.lua:164:        -- TODO
nselib/eigrp.lua:168:        -- TODO
nselib/eigrp.lua:218:        -- TODO
nselib/eigrp.lua:222:        -- TODO
nselib/eigrp.lua:226:        -- TODO
nselib/eigrp.lua:230:        -- TODO
nselib/eigrp.lua:336:          -- TODO
nselib/eigrp.lua:339:          -- TODO
nselib/eigrp.lua:347:          -- TODO
nselib/eigrp.lua:350:          -- TODO
nselib/eigrp.lua:353:          -- TODO
nselib/eigrp.lua:356:          -- TODO
nselib/eigrp.lua:359:          -- TODO
nselib/eigrp.lua:362:          -- TODO
nselib/eigrp.lua:365:          -- TODO
nselib/eigrp.lua:368:          -- TODO
nselib/eigrp.lua:371:          -- TODO
nselib/eigrp.lua:374:          -- TODO
nselib/eigrp.lua:377:          -- TODO
nselib/http.lua:106:-- TODO
nselib/ipOps.lua:777:    -- TODO: Perhaps we should support extracting IPv4 from IPv4-mapped addresses?
nselib/json.lua:113:  json = V "space"^0 * V "value" * V "space"^0 * P(-1); -- FIXME should be 'V "object" + V "array"' instead of 'V "value"' ?
nselib/ldap.lua:522:-- TODO: Add decoding of missing attributes
nselib/ldap.lua:523:-- TODO: Add decoding of userParameters
nselib/ldap.lua:524:-- TODO: Add decoding of loginHours
nselib/ldap.lua:568:-- TODO: Add decoding of missing attributes
nselib/ldap.lua:569:-- TODO: Add decoding of userParameters
nselib/ldap.lua:570:-- TODO: Add decoding of loginHours
nselib/msrpc.lua:3345:  --        [in/*FIXME:,length_is(NumArgs)*/] [string,charset(UTF16)] uint16 *Arguments
nselib/msrpc.lua:3362:  --        [in/*FIXME:,length_is(NumArgs)*/] [string,charset(UTF16)] uint16 *Arguments
nselib/msrpc.lua:3498:    -- TODO
nselib/msrpc.lua:3910:  -- Vista doesn't like a 'null' after the server name, so fix that (TODO: the way I strip the null here feels hackish, is there a better way?)
nselib/msrpc.lua:4038:-- TODO: Caching, store this in the registry
nselib/msrpc.lua:4444:  -- Wait for it to start (TODO: Check the query result better)
nselib/msrpc.lua:4526:  -- Wait for it to stop (TODO: Check the query result better)
nselib/msrpcperformance.lua:229:  pos, result['ObjectNameTitle']      = msrpctypes.unmarshall_int32(data, pos) -- TODO: will this work with 64-bit?
nselib/msrpcperformance.lua:231:  pos, result['ObjectHelpTitle']      = msrpctypes.unmarshall_int32(data, pos) -- TODO: will this workw ith 64-bit?
nselib/omp2.lua:77:    -- TODO escape credentials
nselib/rmi.lua:296:    -- TODO: Make utf-8 of it
nselib/rmi.lua:745:  dos:writeUTF("127.0.0.1") -- TODO, write our own ip instead (perhaps not necessary, since we are not using MultiplexProtocol
nselib/rmi.lua:1379:    --TODO, add this (will throw error as is)
nselib/rpc.lua:529:  -- TODO: add more Authentication Protocols
nselib/rpc.lua:536:  -- TODO: complete Authentication stats and error messages
nselib/rpc.lua:2553:    -- TODO: recheck the version mismatch when adding NFSv4
nselib/rpc.lua:2626:    -- TODO: recheck the version mismatch when adding NFSv4
nselib/rpc.lua:2702:    -- TODO: recheck the version mismatch when adding NFSv4
nselib/rsync.lua:136:  -- TODO: Add support for parsing results, seemed straight forward at
nselib/sip.lua:195:  -- TODO: We should probably send some "closing" packets here
nselib/smb.lua:1957:    #write_data,-- Data length low -- TODO: set this properly (to the 2-byte value)
nselib/smb.lua:2807:        -- TODO: cleanup fe.s_fname
nselib/smb.lua:3390:-- TODO: At some point, I should re-do this function properly, with a method of
nselib/smbauth.lua:161:  -- Save the username in a global list -- TODO: restore this
nselib/smbauth.lua:278:  -- Add the account given on the commandline (TODO: allow more than one?)
nselib/smbauth.lua:759:    -- Convert the username and domain to unicode (TODO: Disable the unicode flag, evaluate if that'll work)
nselib/sslcert.lua:42:  -- TODO: Implement STARTTLS for NNTP
nselib/stdnse.lua:930:    if((key == nil or key == k) and (v == value)) then -- TODO: if 'value' is a table, this fails
nselib/tls.lua:1160:    -- TODO: implement reading of fragmented records
nselib/tls.lua:1224:        -- TODO: implement other handshake message types
nselib/vulns.lua:2140:    -- TODO: CPE support
nsock/src/nsock_event.c:376:  /* FIXME: We should be updating stats here ... */
nsock/src/proxy_http.c:153:  /* TODO string check!! */
scan_engine.cc:712:  /* TODO: This should perhaps differ by scan type. */
scan_engine.cc:1491:  assert(0); /* TODO: need to handle other protocols */
scan_engine.cc:1850:    /* TODO: I need more code here to determine when a state should
scan_engine.cc:2335:    /* TODO: Support any other probe types */
scan_engine_raw.cc:1581:        /* TODO: I suppose I should really mark the @@# host as up */
scan_engine_raw.cc:1588:      /* TODO: Set target mac */
scan_engine_raw.cc:1654:        /* TODO: I suppose I should really mark the @@# host as up */
scan_engine_raw.cc:1661:      /* TODO: Set target mac */
scan_engine_raw.cc:1948:          /* TODO: IPID verification */
scan_engine_raw.cc:2077:          /* TODO: IPID verification */
scripts/bacnet-info.nse:834:  else -- TODO: other encodings not supported by unicode.lua
scripts/couchdb-databases.nse:33:-- TODO : Authentication not implemented
scripts/firewalk.nse:80:-- TODO
scripts/giop-info.nse:55:    -- TODO: Handle t.kind? May require IDL.
scripts/http-enum.nse:74:-- TODO
scripts/http-enum.nse:78:-- File extensions (TODO: Implement this)
scripts/http-fileupload-exploiter.nse:28:-- TODO:
scripts/http-fileupload-exploiter.nse:185:      -- FIXME: What if there is more than one <input type="file">?
scripts/http-form-fuzzer.nse:19:-- TODO: develop more sophisticated techniques that will let us determine if the fuzzing was
scripts/http-robtex-shared-ns.nse:25:-- TODO:
scripts/http-vuln-cve2013-0156.nse:13:TODO:
scripts/http-vuln-cve2013-7091.nse:14:TODO:
scripts/http-vuln-cve2013-7091.nse:40:-- |       TODO:
scripts/http-waf-fingerprint.nse:53:-- TODO:    Fingerprints for other WAFs
scripts/http-waf-fingerprint.nse:133:  -- TODO Check if version detection is possible
scripts/http-waf-fingerprint.nse:142:        if http.response_contains(response, reason, true) then -- TODO Replace with something more performant
scripts/http-waf-fingerprint.nse:163:        -- TODO Check if version detection is possible
scripts/http-waf-fingerprint.nse:213:        -- TODO Check accuracy
scripts/http-waf-fingerprint.nse:234:      -- TODO Check for version detection possibility
scripts/http-waf-fingerprint.nse:335:      -- TODO Check for other version detection possibilities
scripts/http-waf-fingerprint.nse:349:      -- TODO Does X-CLIENT-IP apply to Citrix Application Firewall too ?
scripts/http-waf-fingerprint.nse:516:      -- The default SecServerSignature value is "NOYB" <= TODO For older versions, so we could
scripts/http-wordpress-enum.nse:26:TODO:
scripts/ms-sql-query.nse:73:  -- TODO: consider renaming this arg to ms-sql-query.database
scripts/smb-brute.nse:235:  -- Otherwise, base the type on the operating system (TODO: other versions of Windows (7, 2008))
scripts/smb-check-vulns.nse:585:      table.insert(response, get_response("MS08-067", "LIKELY VULNERABLE", "host stopped responding",         1)) -- TODO: this isn't very accurate
scripts/smb-enum-domains.nse:65:-- TODO: This script needs some love...
scripts/smb-enum-groups.nse:162:      -- TODO: Map SIDs to names, show non-named SIDs
scripts/smb-psexec.nse:409:Some ideas for later versions (TODO):
scripts/smb-system-info.nse:61:-- TODO: This script needs some love
scripts/smb-system-info.nse:143:  -- TODO: Known DLLs?
scripts/snmp-info.nse:56:-- TODO: This should probably check for version 1 and version 2, since those
scripts/snmp-info.nse:89:    -- TODO: at least report the security model in use
scripts/ssl-enum-ciphers.nse:509:                -- TODO: reorder certificates and validate entire chain
scripts/ssl-enum-ciphers.nse:510:                -- TODO: certificate validation (date, self-signed, etc)
scripts/ssl-enum-ciphers.nse:511:                -- TODO: Handle this gracefully when OpenSSL is not compiled in
scripts/ssl-enum-ciphers.nse:523:                      -- TODO: Update this when SHA-1 is deprecated in 2016
scripts/ssl-poodle.nse:315:  -- TODO: remove this check after the next release.
scripts/targets-ipv6-map4to6.nse:164:  -- TODO: Gather IPv6 subnets from other sources.
scripts/xmpp-info.nse:391:        --TODO: Add more hints
service_scan.cc:824:https:// FIXME: The newstrlen argument is not actually checked, is it?
service_scan.cc:1900:  // TODO: Come up with better ways to determine ideal_parallelism
service_scan.cc:2450:      // TODO: For efficiency I should be able to test if enough data
service_scan.cc:2484:      // TODO:  Perhaps should do further verification before making this assumption
service_scan.cc:2502:        // TODO:  Perhaps should do further verification before making this assumption
tcpip.cc:1765:    // FIXME: I eventually need to figure out why Windows head.ts time is sometimes BEFORE the time I
timing.cc:326:  /* TODO: I should revisit these values for tuning.  They should probably
utils.cc:648:/* FIXME:  From the looks of it, this function can only handle one mmaped file
utils.cc:706:/* FIXME:  This only works if the file was mapped by mmapfile (and only
zenmap/zenmapCore/NetworkInventory.py:393:            # TODO: Filename security checks?
zenmap/zenmapCore/NetworkInventory.py:472:    # FIXME: This method doesn't do anything.  We just need to support
zenmap/zenmapGUI/higwidgets/higspinner.py:453:        # FIXME, this should really come from the pixbuf size + margins
zenmap/zenmapGUI/higwidgets/higtables.py:141:    # TODO: