Set the service contract for LogReceiverTarget as one way #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request. Will this change be breaking? |
|
Yes you are right. I don't know what I was thinking. I will make some changes to allow the selection of the service contract through an optional property of the LogReceiverTarget, with the default value being the current two-way contract. This way it will be non breaking and will support the feature I need for multicast. |
…ight way. By default, the target still use the two way contract, so it doesn't change anything. But a new optional property was added to the target to specify which contract to use. The one way contract has a new set of interfaces, so to use it, these new interfaces must be used/implemented instead of the old ones.
|
Thanks for the pull request, it looks good. |
ghost
pushed a commit
that referenced
this pull request
Feb 13, 2015
Set the service contract for LogReceiverTarget as one way
ghost
merged commit 
ghost
added this to the 
|
Is #106 related? |
|
Yes #106 is about the same thing (IsOneWay property) in a different usage scenario (MSMQ). The changes I made should allow it to works with MSMQ when the new property of the target is set. |
|
Thanks @MartinTherriault |
This was referenced Jul 1, 2015
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the service contract for the LogReceiverTarget to be one way. This will allow the messages to be multicast through a WCF routing service.
See issue #561 for more details.