Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stacktraceusage with more than 1 rule #1364

Merged
merged 2 commits into from
Apr 5, 2016

Conversation

304NotModified
Copy link
Member

This was broken due to too aggressive caching.

This was working:

<nlog>
   <targets>
       <target name='debug' type='Debug' layout='${message}' />
       <target name='debug2' type='Debug' layout='${callsite} ${message}' />
   </targets>
   <rules>
       <logger name='*' minlevel='Debug' writeTo='debug2' />
       <logger name='*' minlevel='Debug' writeTo='debug' />
   </rules>
</nlog>

and this wasn't (nullref in stacktrace renderer, because of maxstacktrace = none)

<nlog>
   <targets>
       <target name='debug' type='Debug' layout='${message}' />
       <target name='debug2' type='Debug' layout='${callsite} ${message}' />
   </targets>
   <rules>
       <logger name='*' minlevel='Debug' writeTo='debug' />
       <logger name='*' minlevel='Debug' writeTo='debug2' /> 
   </rules>
</nlog>

fixes #1363

@304NotModified 304NotModified added the bug Bug report / Bug fix label Apr 5, 2016
@304NotModified 304NotModified added this to the 4.3 milestone Apr 5, 2016
@codecov-io
Copy link

Current coverage is 75.18%

Merging #1364 into master will increase coverage by +0.01% as of e60a2c9

@@            master   #1364   diff @@
======================================
  Files          267     267       
  Stmts        15526   15528     +2
  Branches      1631    1631       
  Methods          0       0       
======================================
+ Hit          11672   11674     +2
  Partial        383     383       
  Missed        3471    3471       

Review entire Coverage Diff as of e60a2c9


Uncovered Suggestions

  1. +0.09% via ...gingConfiguration.cs#374...387
  2. +0.09% via ...gingConfiguration.cs#340...353
  3. +0.08% via ...argets/FileTarget.cs#1713...1725
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@304NotModified 304NotModified merged commit 43b8e1c into master Apr 5, 2016
@304NotModified 304NotModified deleted the fix-stacktraceusage-two-error-rules branch April 12, 2016 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report / Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants