Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better unit test cleanup between tests + fix threadsafe issue ScanProperties #1214

Merged
merged 5 commits into from
Feb 4, 2016
Merged

Better unit test cleanup between tests + fix threadsafe issue ScanProperties #1214

merged 5 commits into from
Feb 4, 2016

Conversation

304NotModified
Copy link
Member

found threadsafe issue in ScanProperties and fixed it

@codecov-io
Copy link

Current coverage is 73.97%

Merging #1214 into master will decrease coverage by -0.17% as of 4f60ba6

@@            master   #1214   diff @@
======================================
  Files          265     265       
  Stmts        15283   15301    +18
  Branches      1677    1681     +4
  Methods          0       0       
======================================
- Hit          11332   11319    -13
- Partial        416     418     +2
- Missed        3535    3564    +29

Review entire Coverage Diff as of 4f60ba6

Uncovered Suggestions

  1. +0.09% via ...argets/FileTarget.cs#1691...1703
  2. +0.08% via ...gingConfiguration.cs#282...293
  3. +0.08% via ...gingConfiguration.cs#244...255
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@304NotModified 304NotModified changed the title Better unit test cleanup between tests Better unit test cleanup between tests + fix threadsafe issue Feb 3, 2016
@304NotModified 304NotModified changed the title Better unit test cleanup between tests + fix threadsafe issue Better unit test cleanup between tests + fix threadsafe issue ScanProperties Feb 3, 2016
@304NotModified 304NotModified added the enhancement Improvement on existing feature label Feb 3, 2016
@304NotModified 304NotModified added this to the 4.3 milestone Feb 3, 2016
304NotModified added a commit that referenced this pull request Feb 4, 2016
@304NotModified
Merge pull request #1214 from NLog/internallogger-no-side-effects
18a7e20 
Better unit test cleanup between tests + fix threadsafe issue ScanProperties
@304NotModified 304NotModified merged commit 18a7e20 into master Feb 4, 2016
@304NotModified 304NotModified deleted the internallogger-no-side-effects branch February 5, 2016 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Improvement on existing feature unit-tests
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@304NotModified @codecov-io