-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coloredconsole not compiled regex by default #1171
Conversation
Use Regex cache by default
Current coverage is
|
Is someone would review this, that would be great :) |
How about supplementing one of the tests to test with both |
return this.CompiledRegex.Replace(message, new MatchEvaluator(this.MatchEvaluator)); | ||
if (CompileRegex) | ||
{ | ||
return this.CompiledRegex.Replace(message, this.MatchEvaluator); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should check if CompiledRegex
is null here and then return just message
.
Thanks @bhaeussermann ! |
Fixes after review applied! |
It looks good to me! Will you update the Wiki? Then I'll merge. |
Coloredconsole not compiled regex by default
CompileRegex
option,false
by default. Iffalse
the Regex Cache is used.fixes #764