Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asynchronous dowloads of dependencies. #938

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bobeff
Copy link
Contributor

@bobeff bobeff commented Sep 8, 2021

This pull request is a work in progress intended to be a starting point for those who want to finish this feature. Currently, it is not working stably and random crashes, stalls, and other misbehaviors are observed caused by bugs in the asynctools library or in the Nim's standard library asyncdispatch module. Also, is left to be implemented a limit of maximum async downloads when downloading free (not locked) dependencies.

This commit implements parallel downloads of free not locked
dependencies. It is currently buggy. There are two problems:

 - Stall when downloading dependencies.

 - Error: "No handles or timers registered in dispatcher." in
   "do not install single dependency multiple times (nim-lang#678)" test.
@bobeff bobeff marked this pull request as draft September 8, 2021 17:15
yyoncho pushed a commit to yyoncho/nimble that referenced this pull request Aug 23, 2022
- implementation of async download based on chronos asyncproc
- the PR is based on nim-lang#938
yyoncho pushed a commit to yyoncho/nimble that referenced this pull request Aug 23, 2022
- implementation of async download based on chronos asyncproc
- the PR is based on nim-lang#938
yyoncho pushed a commit to yyoncho/nimble that referenced this pull request Aug 24, 2022
- implementation of async download based on chronos asyncproc
- the PR is based on nim-lang#938
yyoncho pushed a commit to yyoncho/nimble that referenced this pull request Aug 24, 2022
- implementation of async download based on chronos asyncproc
- the PR is based on nim-lang#938
yyoncho pushed a commit to yyoncho/nimble that referenced this pull request Aug 24, 2022
- implementation of async download based on chronos asyncproc
- the PR is based on nim-lang#938
yyoncho pushed a commit to yyoncho/nimble that referenced this pull request Aug 24, 2022
- implementation of async download based on chronos asyncproc
- the PR is based on nim-lang#938
yyoncho pushed a commit to yyoncho/nimble that referenced this pull request Aug 24, 2022
- implementation of async download based on chronos asyncproc
- the PR is based on nim-lang#938
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant