Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create and edit json metadata file #44

Open
fullcavediver opened this issue Jan 24, 2024 · 9 comments
Open

create and edit json metadata file #44

fullcavediver opened this issue Jan 24, 2024 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@fullcavediver
Copy link

Hi @nicorac,
Your bcr-gui also works perfectly with other call recorders, such as Huawei Call Recorder Service.
Unfortunately, this call recorder cannot create metadata file. Would it be possible to implement this feature in bcr-gui and allow creating the metadata file and editing comments?
That would be great!
Thank you very much!

Best regards
Cavediver

brc-gui_dark_new

@fullcavediver fullcavediver added the enhancement New feature or request label Jan 24, 2024
@nicorac
Copy link
Owner

nicorac commented Jan 24, 2024

Notes are not available (yet); it's a feature I'll add in the future.
I'm sorry you were misled by the screenshot (will fix it soon 😉).

Anyway there won't be need for "metadata file"... metadata file (generated by BCR) is used only to easily get recording data (like CallerID, Caller number, Call length, ...) without parsing filename and analyze audio file.
If that file is missing, as a fallback these data are "extracted" from filename.

Once "Notes" feature will be implemented, its data will be stored in BCR-GUI own database file...

Your bcr-gui also works perfectly with other call recorders, such as Huawei Call Recorder Service.

Thanks for reporting it.
I suppose you've set a custom filename parser pattern to extract data from filenames.
If you'd like to share the default Huawei Call Recorder Service filename pattern, I'll add it to default app templates 👍

@fullcavediver
Copy link
Author

fullcavediver commented Jan 24, 2024

Thank you @nicorac! That would be great! Thanks!

I know a “metadata file” is not needed, but I want to add notes to the call and a metadata file would be a perfect place here. This would make it easier to search for specific keywords.

I created the screenshot myself to show you what I meant - that was just my suggestion :-)

If you'd like to share the default Huawei Call Recorder Service filename pattern, I'll add it to default app templates

very gladly!

^{caller_name}@{phone_number}_{date:year}{date:month}{date:day}{date:hours}{date:minutes}{date:seconds}

How is the json metadata files structured? Are there tools to easily create the file?

@nicorac
Copy link
Owner

nicorac commented Jan 24, 2024

very gladly!
^{caller_name}@{phone_number}_{date:year}{date:month}{date:day}{date:hours}{date:minutes}{date:seconds}

Thanks, will add it to next release.

How is the json metadata files structured? Are there tools to easily create the file?

Why do you need to create such file?
Do you need to add additional data not "printed" in filename?
Again, BCR-GUI does not write anything to it; it only reads out some fields...

Anyway, this is a sample .json metadata file, with the same schema as the ones created by BCR:
test_file_0001.json

@nicorac
Copy link
Owner

nicorac commented Jan 24, 2024

Are there tools to easily create the file?

The original intent of BCR-GUI was to be a companion app of BCR (Basic Call Recorder).
There's no "tool" to create those metdata files, they're created by BCR just after call recording terminates 😉

@fullcavediver
Copy link
Author

Why do you need to create such file?

I'm looking for an easy way to quickly enter some important information after a conversation. With BCR-GUI this would be very easy: end the conversation -> open BCR-GUI -> click on entry -> add note.

What is the note/comment variable called and where is it located in the structure of .json file?

@nicorac
Copy link
Owner

nicorac commented Jan 24, 2024

Notes are not contained in Metadata file and, again, are not actually managed (nor shown) by BCR-GUI.

It's a feature I'll add in a future version, not available now. Once added, you'll be able to add notes & tags through BCR-GUI app.

@fullcavediver
Copy link
Author

Sorry @nicorac for the misunderstanding

Notes are not contained in Metadata file

I assumed that the notes from your screenshot above: "Notes: Lorem ipsum dolor sit amet..." came from the .json file, so I thought that this file was created by BCR and read by BCR-GUI. When I saw my calls in BCR-GUI, I read everywhere: "Missing json metadata file!" When I created the empty file myself, this information was gone but there was no "Notes:" field so I thought - you can easily create it with the BCR-GUI. Sorry again for the confusion.

It's a feature I'll add in a future version

I'm waiting for further development and wish you much success!

@nicorac
Copy link
Owner

nicorac commented Jan 25, 2024

Notes are not available (yet); it's a feature I'll add in the future.
I'm sorry you were misled by the screenshot (will fix it soon 😉).

Yeah, I meant my screenshot was misleading (the one you see in project homepage); you've only added an additional button to it, but the "Notes:" section in the original screenshot image was only a mockup (will fix it ASAP).

When I saw my calls in BCR-GUI, I read everywhere: "Missing json metadata file!"

That message is, now that you pointed it out, almost useless to the user; it was added to debug the app at early stage 😉
Will remove it, won't help the user (nor me) and could lead user think there's something wrong.

Sorry again for the confusion.

No worries, thanks for your suggestions 👍

@fullcavediver
Copy link
Author

I thank you!

I once tried Cube Call Recorder ACR - this app saves notes in a .json file so I thought I can extend this missing feature in BCR with BCR-GUI. I had problems with Cube Call Recorder on my Huawai smartphone and I cannot use BCR because my smartphone cannot be rooted

I look forward to your next releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants