Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find contacts with phone number without country code. #122

Open
loziniak opened this issue May 28, 2024 · 5 comments
Open

Find contacts with phone number without country code. #122

loziniak opened this issue May 28, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@loziniak
Copy link
Contributor

loziniak commented May 28, 2024

Hello. When there is a call recorded with number "+48123456789" and I have a contact in my contact book with a number "123456789", I'd like it to be found as well.

@loziniak loziniak added the enhancement New feature or request label May 28, 2024
@nicorac
Copy link
Owner

nicorac commented May 28, 2024

This feature already exists.
Just set your country prefix (i.e. +48 in your case) in "Default country prefix" app setting.

@ngocanhtve
Copy link
Contributor

ngocanhtve commented Jun 1, 2024

This feature already exists.
Just set your country prefix (i.e. +48 in your case) in "Default country prefix" app setting.

I have another small issue.

Ex: An incoming call has the number +84 987 654 321, but the actual number stored in the phonebook is 0987 654 321. So even if I set the prefix +84, there is still a missing 0. Right?

And one more small issue.

When an incoming call is displayed as 0987 654 321. But in the phonebook it is +84 987 654 321. It still does not detect properly. This is an actual case I encountered just this morning.

@nicorac
Copy link
Owner

nicorac commented Jun 5, 2024

Ex: An incoming call has the number +84 987 654 321, but the actual number stored in the phonebook is 0987 654 321. So even if I set the prefix +84, there is still a missing 0. Right?

Yes, you're right, it currently work like that.

Are you saying that the area code leading 0 is needed only when calling from inside the country and should (must) be removed when calling from outside the country?

I mean:

  • from inside the country: 0 + Area Code + Phone Number
  • from outside the country: +84 + Area Code + Phone Number

Do you confirm?

If so, we should find a way to let user remove that leading zero before prepending the international prefix.
I wonder if it could lead to false positives...

AFAIK the international prefix (+84) is completely prepended to default (local) phone number, which remains unchanged.
When locally calling that number could you dial both 987 654 321 and 0987 654 321

@nicorac
Copy link
Owner

nicorac commented Jul 4, 2024

This is becoming stale, will close it soon...

@ngocanhtve
Copy link
Contributor

ngocanhtve commented Jul 5, 2024

This is becoming stale, will close it soon...

Sorry, I forgot the comment in this issue.

In my country phone numbers will start with 0, which will be replaced by +84 in some cases. That means if a phone number, for example +84 987 654 321, will actually be 0987 654 321.

I just wonder is that after setting the country prefix to +84, that means the application will automatically cut off +84, leaving the number 987 654 321 instead of 0987 654 321.

At this time, I have saved 0987 654 321 in my contacts, will a number calling +84 987 654 321 be detected? Because after cutting off +84, only 987 654 321 remained. It did not match 0987 654 321 because it lost a 0.

So the question is to completely cut off +84 or replace +84 with 0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants