Add discord's media domain to blocklist-discord.txt using the ABP blocklist style. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discord has migrated to using around 9999 per server location of subdomains of the .discord.media domain to facilitate connecting to voice calls and voice channels, even when the main application is not accessible. Since 2023 Pihole supports limited ABP style blocklists. This commit makes use of this feature to block all discord.com domains and all discord.media subdomains, ensuring the application is completely and properly blocked, even when the app was opened once on another network.
|
Thankyou Marc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discord has migrated to using around 9999 per server location of subdomains of the .discord.media domain to facilitate connecting to voice calls and voice channels, even when the main application is not accessible. This means that 9999 * 14 locations = ~14000 subdomains have to be blocked, which has to be kept up for every location update.
Since March of 2023 Pihole supports limited ABP style blocklists. (Pull request: pi-hole/pi-hole/pull/5179)
This commit makes use of this feature to block all discord.com (sub)domains and all discord.media subdomains, ensuring the application is completely and properly blocked, even when new Voice Server locations are added, or when the app was opened once on another network.
This will not be backwards compatible with earlier versions of PiHole. If maintaining backwards compatibility with 1yrd old versions is necessary, I am able to revert the blocklist-discord.txt file and make this change as a seperate, new file.