Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Has DATABASE_URL been dropped? #655

Open
joshmedeski opened this issue Oct 4, 2021 · 1 comment
Open

Has DATABASE_URL been dropped? #655

joshmedeski opened this issue Oct 4, 2021 · 1 comment

Comments

@joshmedeski
Copy link
Contributor

Has DATABASE_URL been dropped in the latest version of Hasura Backend Plus?

If so, it should be removed from the project completly:

$ rg "DATABASE_URL"

src/shared/migrations.ts
8:    connectionString: process.env.DATABASE_URL

src/test/global-setup.ts
10:    connectionString: process.env.DATABASE_URL

docker/dev/docker-compose-example.yaml
20:      HASURA_GRAPHQL_DATABASE_URL: >-
46:      DATABASE_URL: >-

docs/docs/getting-started/setup.md
47:      HASURA_GRAPHQL_DATABASE_URL: >-
69:      DATABASE_URL: >-

docker/dev/docker-compose-example2.yaml
19:      HASURA_GRAPHQL_DATABASE_URL: >-

docker/test/docker-compose-test.yaml
20:      HASURA_GRAPHQL_DATABASE_URL: >-
46:      DATABASE_URL: >-

I was using it previously and I didn't notice in the release notes that direct database communication was completely removed in a recent version of HBP.

@joshmedeski
Copy link
Contributor Author

Okay, did some tests and found out the migration mechanism when the Docker container starts up is using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant