Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing localization keys + using 2 different naming conventions for the keys #885

Open
YanivWein24 opened this issue Aug 27, 2023 · 0 comments
Labels

Comments

@YanivWein24
Copy link

I created an object for Hebrew localization and added it to "includeUI".
When I started translating the image editor I noticed that there are 2 naming conventions for keys with more than 1 word.

one convention is PascalCase keys. for example:

{ 
  DeleteAll: "Lorem Ipsum",
  ZoomIn: "Lorem Ipsum",
  ZoomOut: "Lorem Ipsum"
}

And the other convention is kebab-case keys. for example:

{
  "Custom icon": "Lorem Ipsum",
  "Flip X":"Lorem Ipsum",
  "Flip Y": "Lorem Ipsum"
}

Using different naming conventions for the localization keys is not ideal and it makes it more difficult and time-consuming to translate the editor.

Furthermore, I didn't find the right keys for the following texts:

{
  "Remove white": "הסר לבן", 
  "Color filter": "פילטר צבע", 
  "Load mask image": "טען תמונה", 
}

I have also tried different combinations like "RemoveWhite", "Remove-White", "Remove-white" etc.
Still couldn't find the right keys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant