Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to run tests on this project? #747

Closed
Mouradif opened this issue Mar 31, 2022 · 6 comments
Closed

How to run tests on this project? #747

Mouradif opened this issue Mar 31, 2022 · 6 comments
Labels

Comments

@Mouradif
Copy link

In many projects I saw, there's a npm "test" script that lets you just run yarn test or npm run test and it should work out of the box.

In this project, I saw that jest was a dependency so I assumed I'd run npx jest but all the tests fail because imports with the @/ prefix are not resolved. What's the correct way to run tests?

Also consider adding the answer to this question to the README.md

@lja1018
Copy link
Contributor

lja1018 commented Apr 6, 2022

@Mouradif
Have you run npm run test on apps/image-editor?

@Mouradif
Copy link
Author

Mouradif commented Apr 6, 2022

I have now, thanks.

@lja1018 lja1018 closed this as completed Apr 13, 2022
@Mouradif
Copy link
Author

@lja1018 has this been fixed?

@lja1018
Copy link
Contributor

lja1018 commented Apr 20, 2022

@Mouradif
I don't know what the problem is because the test runs without any problems.

@Mouradif
Copy link
Author

Sorry, I actually realize that my message "I have now, thanks." is incomplete. I originally added that this should be in the CONTRIBUTING.md file where it says to run npm run test because one would assume this command should run on the root folder, unless I'm missing something

@lja1018
Copy link
Contributor

lja1018 commented Apr 20, 2022

@Mouradif
I understand. I think it's reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants