Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call addText method and revise immediately space not working #709

Open
eomttt opened this issue Feb 11, 2022 · 6 comments
Open

call addText method and revise immediately space not working #709

eomttt opened this issue Feb 11, 2022 · 6 comments
Labels

Comments

@eomttt
Copy link

eomttt commented Feb 11, 2022

Describe the bug
when i use addText method.
textarea open and focusing but when i typing english or number and after typing space focus out textarea
but korean is work very well (but when i typing korean and after click space twice, fire same)

example

abc(space)<- focus out
123(space)<- focus out
가나다(space)라마바사<- work well
가나다(space)(space)<-focus out

and it also fire at first time
when i call addText and delete placeholder and same typing above doesn't file
only fire when call addText and immediately write.
so i think it's problem with addText method

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'call addText method'
  2. Typing any text and type space after
  3. textarea focused out -> but when i double click textarea after focus out and revise work very well

Expected behavior
Not focusing out

Screenshots
https://user-images.githubusercontent.com/22593217/153546996-12e96507-f4e0-4a1f-94b1-f2eb3dff7f29.mov

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@eomttt eomttt added the Bug label Feb 11, 2022
@eomttt
Copy link
Author

eomttt commented Feb 11, 2022

i debug some case.
when i click space textarea tag detached in body tag at first time

@eomttt
Copy link
Author

eomttt commented Feb 11, 2022

i forked repo and make new html for test my issue
eomttt@456921f

open dev serve and check please

@eomttt
Copy link
Author

eomttt commented Feb 11, 2022

bug-test.mov

@lja1018
Copy link
Contributor

lja1018 commented Feb 16, 2022

@eomttt
Thank you for reporting the bug.
The bug is not reproduced. Can you tell me how to reproduce it in detail?

@eomttt
Copy link
Author

eomttt commented Feb 16, 2022

@eomttt Thank you for reporting the bug. The bug is not reproduced. Can you tell me how to reproduce it in detail?

You can see my commit (eomttt@456921f)
and show example04-add-text.html file and produce this html in your dev server.

한국말로 하자면....
addText 메소드 실행 후, 텍스트박스가 생기면 그때 한글을 제외한 영어나 숫자를 입력하다가 스페이스를 입력하면 텍스트 박스에서 포커스가 아웃됩니다.
한글 인경우 연속으로 스페이스를 치면 텍스트 박스에서 포커스가 아웃됩니다.

조금 코드를 찾아보니 autofocus 인 경우에 events.TEXT_EDITING 이벤트가 발생 안되어서 zoom.js 에서 _startHandModeWithSpaceBar 메소드에서 this.isTextEditing 이 아직 false 여서 스페이스시 this.startHandMode 메소드가불려서 포커스가 없어집니다.

r그래서 PR 도 열어 봤습니다. (#711)

@lja1018
Copy link
Contributor

lja1018 commented Feb 16, 2022

@eomttt
I succeeded in reproducing it. Thank you for the information.
I will comment on the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants