Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag 3.14.3 does not have dist folder #595

Open
david10sing opened this issue May 18, 2021 · 6 comments
Open

Tag 3.14.3 does not have dist folder #595

david10sing opened this issue May 18, 2021 · 6 comments
Labels

Comments

@david10sing
Copy link

3.14.3

Trying to use version 3.14.3

Current Behavior

On NPM v3.14.3 it seems that the package is missing the dist folder.

@Mouradif
Copy link

Mouradif commented May 19, 2021

I had the same problem, I installed tui-image-editor@^3.11.0 instead, it actually installs 3.14.3 but with a dist folder

@lja1018
Copy link
Contributor

lja1018 commented May 20, 2021

@david10sing @Mouradif
Thank you for the information.
It is probably a bug that occurred after the mono-repo application of v3.12.0. I will resolve it after checking it.

@lja1018 lja1018 added the Bug label May 20, 2021
@lja1018
Copy link
Contributor

lja1018 commented May 20, 2021

@david10sing @Mouradif
I checked 3.14.3 contained dist directory (both npm install & zip file on 3.14.3)
Could you tell me how to reproduce it in detail?

@Mouradif
Copy link

I just reproduced the steps I did before and dist folder is here indeed :/ must have been a temporary bug with npm registry

@AFPMedialab
Copy link

Same bug, dist folder is not set when using v.3.14.3 I have downgrade to v.3.14.2 to have it worked

@FrozenKiwi
Copy link

I had the same problem. I downloaded the archive direct from npm (https://registry.npmjs.org/@toast-ui/react-image-editor/-/react-image-editor-3.14.3.tgz) and peeked inside it is missing the dist folder there too.

Very odd, but any chance could try cutting a new release?

Ps: if you want, would you have anything against a PR putting in the (minimal, but still very useful) typescript definitions referenced in another issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants