Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom crop presets #567

Closed
ziga-miklic opened this issue Mar 31, 2021 · 4 comments
Closed

Custom crop presets #567

ziga-miklic opened this issue Mar 31, 2021 · 4 comments
Labels
Enhancement Enhance performance or improve usability of original features. Need Discussion Need discussion or investigation

Comments

@ziga-miklic
Copy link

Version

3.14.2

Development Environment

Browser: Chrome (89.0.4389.90)
OS: Windows 10 (Version 10.0.19041 Build 19041)

Current Behavior

Currently, the crop functionality inside the image editor has the following presets: Square, 3:2, 4:3, 5:4, 7:5, and 16:9. The current API does not allow changing these presets.

Expected Behavior

An ability to change the presets on the UI options object.

Making the change

We are using the Toast UI Image Editor in our app and it is fantastic! Thank you for all the work you have done.

If we create a PR with the ability to change the crop presets, would you consider merging it into the project? Do you think the feature is something other users would find useful?

Thank you!
@ziga-miklic ziga-miklic added Enhancement Enhance performance or improve usability of original features. Need Discussion Need discussion or investigation labels Mar 31, 2021
@lja1018
Copy link
Contributor

lja1018 commented Apr 7, 2021

@ziga-miklic
Sorry for the late reply. This proposal looks similar to #125 and #350. This option is currently being prepared and will be updated to complete. Thank you!

@ziga-miklic
Copy link
Author

Thank you for responding @lja1018 That is great news!

I look forward to checking out the changes once they are available. Keep up the great work!

@wenjing-pure
Copy link

Any updates？

@lja1018
Copy link
Contributor

lja1018 commented Mar 30, 2022

@wenjing-pure
Sorry. There's no update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Enhance performance or improve usability of original features. Need Discussion Need discussion or investigation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ziga-miklic @lja1018 @wenjing-pure