-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude polyfills from the bundle #450
Labels
Comments
@kaproslaci Thanks for letting me know. I will refer to it for improvement. |
Any updates on this? We also ran into same issue using this library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Including the polyfill causes incompatibilities with other libraries. I'd suggest removing the polyfill from the bundle and include it besides. I reproduced it in a very specific environment but I suppose others may suffer from the issue too. Just by reading issues, similar situations can occur with other components, such as ag-grid, vue-filepond... Also, I think managing outdated browsers and polyfills is the responsibility of the library user, not the library owner (i.e: why the polyfills if someone dropped IE support?)
To Reproduce
Steps to reproduce the behavior:
It is caused by the svgxuse polyfill that will create a MutationObserver which will trigger an infinite loop of dom change for example in the described situation above.
Expected behavior
Include the polyfills separately or just write them into readme so the library users can decide if they wanna use them.
Desktop (please complete the following information):
I reproduced this issue on Chrome and Firefox on Mac and Windows as well. I assume every kind of chrome and Firefox were affected.
The text was updated successfully, but these errors were encountered: