Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tool submenu covers image and image moves into the wrong direction #338

Open
GEMI opened this issue Feb 13, 2020 · 6 comments
Open

Tool submenu covers image and image moves into the wrong direction #338

GEMI opened this issue Feb 13, 2020 · 6 comments
Labels
Enhancement Enhance performance or improve usability of original features.

Comments

@GEMI
Copy link

GEMI commented Feb 13, 2020

Version

TUI image editor 3.7.2

Development Environment

Chrome 79, MacOS Catalina 10.15.2

Current Behavior

When menuBarPosition is top and opening any tool menu Draw, Paint, Crop or any other tool the image container ".tui-image-editor" moves Up instead of Down. So the tool menu covers actual picture and you cannot use the tool on the whole image.

Relevant code is in 'https://github.com/nhn/tui.image-editor/blob/master/src/js/ui.js'

    (menuBarPosition === 'top') {
            if (height > this._editorElementWrap.offsetHeight - 150) {
                top = (150 / 2) - ((height - (this._editorElementWrap.offsetHeight - 150)) / 2);
            }

So for example when height is 800, offset is 736 the result "top" becomes -32. So instead of image going down it goes up and it becomes hard to use the tool on the image.

Image normal
Image moved up

Expected Behavior

When tool menu is expanded and menuBarPosition is "top" the image should move down, not up.

@junghwan-park junghwan-park added the Enhancement Enhance performance or improve usability of original features. label Feb 20, 2020
@GEMI
Copy link
Author

GEMI commented Apr 13, 2020

I would not say this is an enhancement it is a bug, because you cannot draw on the image when the tool menu is covering it. The portion of the image that is covered by the menu is unusable.

Screenshot 2020-04-13 at 11 56 24

@research-scife
Copy link

Any fix ?

@KatGr
Copy link

KatGr commented Apr 30, 2021

Hi,
we have the same problem. We are searching for a tool to edit images in our app and this one would be great but the toolbar is not working on smaller screens.
The menu covers the bottom half of the image so I will never be able to edit this part which makes the tool unusable for us.

@lja1018
Copy link
Contributor

lja1018 commented May 3, 2021

@research-scife @KatGr
I apologize for the inconvenience. The issue has not been worked on yet.
I'll add this issue to our todo list.

@Icc-thang
Copy link

Is there any way to fix this?

@lja1018
Copy link
Contributor

lja1018 commented Jan 12, 2022

@Icc-thang
It hasn't been fixed yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Enhance performance or improve usability of original features.
Projects
None yet
Development

No branches or pull requests

6 participants