Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm install should not be called from package.json postinstall #286

Closed
netik opened this issue Dec 16, 2019 · 2 comments
Closed

npm install should not be called from package.json postinstall #286

netik opened this issue Dec 16, 2019 · 2 comments
Labels
Enhancement Enhance performance or improve usability of original features.

Comments

@netik
Copy link

netik commented Dec 16, 2019

Version

3.4.0 (problem is present in current code as well)

Development Environment

Google Chome, latest

Current Behavior

In the postinstall stanza, the image editor attempts to sneakily install fabric via npm:

 "postinstall": "npm install --no-save --no-optional fabric@^3.3.2"

This breaks projects using yarn. If this package is a dependency, then it should be listed as such and not installed as part of postinstall. If it has to be in postinstal, then you should figure out if the user is running yarn or npm and run the right package manager. This behaviour breaks yarn.

Expected Behavior

Clean package install with proper dependency management.

@jinwoo-kim-nhn
Copy link
Contributor

Previously, if you did not install --no-optional in fabric version 1.6.7, you ran into problems.

The fabric version I currently use has been updated to 3.x.x so there seems to be no problem installing on the dependencies.

Thank you for your feedback and we will test it a bit more and fix it.

@jinwoo-kim-nhn jinwoo-kim-nhn added Enhancement Enhance performance or improve usability of original features. Need Discussion Need discussion or investigation and removed Enhancement Enhance performance or improve usability of original features. Need Discussion Need discussion or investigation labels Jan 7, 2020
@jinwoo-kim-nhn
Copy link
Contributor

It was released in v3.7.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Enhance performance or improve usability of original features.
Projects
None yet
Development

No branches or pull requests

2 participants