Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: default value for ui-tools (#258) #2

Merged
merged 1 commit into from
Oct 28, 2020
Merged

feat: default value for ui-tools (#258) #2

merged 1 commit into from
Oct 28, 2020

Conversation

xea-xray
Copy link
Owner

@xea-xray xea-xray commented Oct 28, 2020 •
edited

override default values for "draw", "shape", "icon" and "text" when used with UI (close nhn#258)

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@phwiget
feat: default value for ui-tools (nhn#258)
2ada969 
override default values for "draw", "shape", "icon" and "text" when used with UI
@xea-xray xea-xray self-assigned this Oct 28, 2020
@xea-xray xea-xray merged commit a3fd9e4 into xea-xray:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@xea-xray xea-xray

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@xea-xray @phwiget