Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagete usageStatistics flag to colorPicker #220

Closed
xasx opened this issue Jul 4, 2019 · 1 comment · Fixed by #223
Closed

Propagete usageStatistics flag to colorPicker #220

xasx opened this issue Jul 4, 2019 · 1 comment · Fixed by #223
Labels

Comments

@xasx
Copy link

xasx commented Jul 4, 2019

Version

v3.5.2

Development Environment

various: Windows, Linux, MacOS
Chrome, Firefox

Current Behavior

The colorPicker component trigger GA calls despite of the image-editor's flag usageStatistics has been set to false.

This induces a privacy issue

// Probably some more options should be in src/js/ui/tools/colorpicker.js

this.picker = tuiColorPicker.create({
            container: this.pickerElement,
            preset: PICKER_COLOR,
            color: defaultColor
        });

Expected Behavior

If the very top component's usageStatistics flag is set to a certain value, especially false, sub-components should take that into account by also setting their usageStatistics flag to the same value.

@junghwan-park
Copy link
Member

@xasx Thank you for your report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants