Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use api direct (basic) is not working on internet explorer 11 #218

Closed
shadabahmad11 opened this issue Jun 29, 2019 · 2 comments · Fixed by #222
Closed

Use api direct (basic) is not working on internet explorer 11 #218

shadabahmad11 opened this issue Jun 29, 2019 · 2 comments · Fixed by #222
Labels
Question

Comments

@shadabahmad11
Copy link

shadabahmad11 commented Jun 29, 2019 •
edited
Loading

Version

v3.6.0

Development Environment

OS: Window 10,
Browser: Internet Explorer 11 and Safari 5.1.7(window 10)

Current Behavior

Image is not loading in internet explorer 11
Page is not loading on window safari.
http:https://nhn.github.io/tui.image-editor/latest/tutorial-example02-useApiDirect
http:https://13.234.119.145/tui.image-editor-production/examples/example02-useApiDirect.html

var imageEditor = new tui.ImageEditor('.tui-image-editor', {
    cssMaxWidth: 700,
    cssMaxHeight: 500,
    selectionStyle: {
        cornerSize: 20,
        rotatingPointOffset: 70
    }
});
I think variable imageEditor is not working.

Expected Behavior

Image should load. I should be able to edit image.
@guillaumegarcia13
Copy link

If you load the example outside ot its iframe: https://nhn.github.io/tui.image-editor/latest/examples/example01-includeUi.html, I assume that is works, right?

The example you are referring to (http:https://nhn.github.io/tui.image-editor/latest/examples/example02-useApiDirect.html) has a service-basic.js file which is not compatible with IE because of unsupported Template literals: https://caniuse.com/#feat=template-literals.

@junghwan-park
Copy link
Member

@shadabahmad11 Oh, I'll change ES6 syntax to ES5. Thank you for your report.

@junghwan-park junghwan-park mentioned this issue Jul 5, 2019
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Change "Use API Direct" example page's ES6 syntax to ES5 fix #218 nhn/tui.image-editor
3 participants
@guillaumegarcia13 @junghwan-park @shadabahmad11