Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't edit (but can see) images from cross domains #207

Closed
roytz opened this issue May 27, 2019 · 11 comments
Closed

Can't edit (but can see) images from cross domains #207

roytz opened this issue May 27, 2019 · 11 comments

Comments

@roytz
Copy link

roytz commented May 27, 2019

Version

3.5.2

Development Environment

MacOS Mojave
Node.js 10.14.0
React 16.8.6

Current Behavior

When using image href of cross domains - I get a "No 'Access-Control-Allow-Origin' header is present on the requested resource" error.
I can see the image (using froala) before opening the TUI advanced-editor, but when opening the advanced editor I get the "No 'Access-Control-Allow-Origin' header is present on the requested resource" error and therefore can't see (inside the advanced-editor) nor edit the image.

can see the image before opening advanced-edit

error when opening advanced-edit

Expected Behavior

Being able to see and edit cross-domains images in TUI advanced editor

@shai32
Copy link

shai32 commented Jun 6, 2019

The same issue happens to me with this file:
https://s3-eu-west-1.amazonaws.com/gf.red.kfdabazdsxc4yyts9.files/froalaFiles1559127824542-flowerofthemonthclub.jpg
from origin:
https://backoffice.general.red.gefen-qa.online

although the s3 is configured property with cross-origin enabled to all domains (with<AllowedOrigin>*</AllowedOrigin>)

also, I executed on terminal:
curl -H "origin: https://backoffice.general.red.gefen-qa.online" -v "https://s3-eu-west-1.amazonaws.com/gf.red.kfdabazdsxc4yyts9.files/froalaFiles1559127824542-flowerofthemonthclub.jpg"
and the file was retrieved ok with no error
so the problem is not in the server

@roytz roytz changed the title Can't edit (but can see) imaged from cross domains Can't edit (but can see) images from cross domains Jun 7, 2019
@roytz
Copy link
Author

roytz commented Jun 13, 2019

After talking to Froala's support team, they also suggested it's related to TAU.
Here's a reproduction of the bug - https://jsfiddle.net/e2b5xyf8/14/

@romanfedyshyn
Copy link

Hi, @jinwoo-kim-nhn do you have any suggestions for what it could be?

@romanfedyshyn
Copy link

@seonim-ryu maybe you can help here?

@romanfedyshyn
Copy link

@junghwan-park any updates?

@romanfedyshyn
Copy link

@seonim-ryu @junghwan-park hello guys, are you going to do something with it?

@junghwan-park
Copy link
Member

@romanfedyshyn Sorry for the late reply.
I think I can resolve loading a cross origin image. But, get imageData from tainted canvas(cross origin image has drawn) is needs to researching.
First, I'll add crossOrigin option for loaded image.

@romanfedyshyn
Copy link

@romanfedyshyn Sorry for the late reply.
I think I can resolve loading a cross origin image. But, get imageData from tainted canvas(cross origin image has drawn) is needs to researching.
First, I'll add crossOrigin option for loaded image.

Hi, just want to ask if you do something with that?

@pegasus1982
Copy link

I have same issue.
How can I solve it?

@stale
Copy link

stale bot commented Mar 12, 2020

This issue has been automatically marked as inactive because there hasn’t been much going on it lately. It is going to be closed after 7 days. Thanks!

@stale stale bot added the inactive label Mar 12, 2020
@stale
Copy link

stale bot commented Mar 19, 2020

This issue will be closed due to inactivity. Thanks for your contribution!

@stale stale bot closed this as completed Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants