Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Free drawing line jump slightly left and top after next editing #167

Closed
junghwan-park opened this issue Mar 15, 2019 · 11 comments
Closed

Free drawing line jump slightly left and top after next editing #167

junghwan-park opened this issue Mar 15, 2019 · 11 comments
Assignees
Labels

Comments

@junghwan-park
Copy link
Member

Version

3.5.0

Development Environment

OSX, Chrome

Current Behavior

Free drawing line jumps after next editing. But Straight line doesn't.

line jumping

line jumping2

Expected Behavior

Free drawing line should not move any pixels.

ref: #151

@junghwan-park junghwan-park added this to the v3.6.0 milestone Mar 15, 2019
@junghwan-park junghwan-park self-assigned this Mar 15, 2019
@zhaoyuhang1033
Copy link

I am the same,in the chrome and vue

@syednoor6208
Copy link

syednoor6208 commented Mar 29, 2019

Free drawing line jumps after next editing.
same issue in react js.

@dexp-io
Copy link

dexp-io commented Jun 24, 2019

@calvinkei
Copy link

any fix yet?

@dexp-io
Copy link

dexp-io commented Jun 29, 2019

Downgrade to 3.3.1 version seems to help

@dimakovalevskyi
Copy link

Try to use fabric.js 1.6.7. It helps me.

@stanleek
Copy link

stanleek commented Jul 17, 2019

downgrade does not help...

line offset is half of previous draw line

@junghwan-park junghwan-park modified the milestones: v3.7.0, v3.8.0 Aug 1, 2019
@Langstra
Copy link

Any idea when this is going to be fixed?

@jinwoo-kim-nhn
Copy link
Contributor

resolved at 3.7.1

@jinwoo-kim-nhn jinwoo-kim-nhn removed this from the v3.8.0 milestone Jan 23, 2020
@DishantOpenxcell
Copy link

DishantOpenxcell commented Nov 30, 2020

I faced the same issue even after you fixed
Even in the documentation, this issue occurring can someone please tell me how to fix this?

@klmaaa
Copy link

klmaaa commented Apr 19, 2024

You should update the brushWidth in tui-image-editor.js as follows:

From

function getBrushSettings() {
  var brushWidth = $inputBrushWidthRange.val();
  var brushColor = brushColorpicker.getColor();

  return {
    width: brushWidth,
    color: hexToRGBa(brushColor, 0.5),
  };
}

To

function getBrushSettings() {
  var brushWidth = parseInt($inputBrushWidthRange.val(), 10);
  var brushColor = brushColorpicker.getColor();

  return {
    width: brushWidth,
    color: hexToRGBa(brushColor, 0.5),
  };
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests