Remove object shape tool

[celeitner]

Shape tool is no longer available after removing the last shape.

1. click shape
2. create square
3. select square
4. click remove selected object
5. no longer can you create a shape

This also happens if I select the shape object and select delete on the keyboard. ( I suspect they both take the same code path - to removeActiveObject() )
I'm not sure where to look to debug this?

[dongsik-yoo]

The removeActiveObject()invokes endDrawingShapeMode(), therefore you should use startDrawingShapeMode() again after removeActiveObject() if you want to stay drawing shape mode.

Thanks a lot.

[celeitner]

That is what I am doing but it does not work. If you have only one shape and remove it then the startDrawingShapeMode() does not work anymore. You can see this in your demo.

click shape
create a square
select the square
click remove active object
no longer can you create a shape

[dongsik-yoo]

I could reproduce what you said. OK I can handle that problem in demo page.

[dongsik-yoo]

This problem was solved. The patch will be included in the next version.

[celeitner]

Can you share the details of the fix? When is the next version going to be released?

[dongsik-yoo]

Below code this.deactivateAll(); line will be removed in the next release version.

[imageEditor.js]

   /**
     * End current action & Deactivate
     * @example
     * imageEditor.startFreeDrawing();
     * imageEidtor.endAll(); // === imageEidtor.endFreeDrawing();
     *
     * imageEditor.startCropping();
     * imageEditor.endAll(); // === imageEidtor.endCropping();
     */
    endAll() {
        this.endTextMode();
        this.endFreeDrawing();
        this.endLineDrawing();
        this.endCropping();
        this.endDrawingShapeMode();
        this.deactivateAll();
        this._state = states.NORMAL;
    }

And we are planning to release the next version at the end of this month.

[dongsik-yoo]

This issue has been solved at v2.0.0.
Please check this out at demo page.