fix(control): avoid throw of error with async validator #98
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When creating a control with an async validator instantly resolved with for example
of(null)
, the extended class (Angular native control) will call the method internally during the class instantiation through thesuper
causing a throw of error since the code except that thesetErrors
has a valid not nilerrorsSubject
.The constructor is creating just after this the subject.
Issue Number: #91
What is the new behavior?
The control's method
setErrors
will no longer throw an error whenerrorsSubject
is not yet created.Does this PR introduce a breaking change?
Other information
Fixes #91