Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disabled$, enabled$ and status$ are typed as any #85

Closed
andreialecu opened this issue Mar 20, 2021 · 1 comment
Closed

disabled$, enabled$ and status$ are typed as any #85

andreialecu opened this issue Mar 20, 2021 · 1 comment

Comments

@andreialecu
Copy link
Contributor

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

In the types exported by this library, disabled$, enabled$ and status$ are typed as any.

FormArray, FormGroup and FormControl all have this problem.

Check out:
https://cdn.jsdelivr.net/npm/@ngneat/[email protected]/lib/formGroup.d.ts

    readonly disabled$: any;
    readonly enabled$: any;
    readonly status$: any;

Expected behavior

They should have the proper type.

@andreialecu
Copy link
Contributor Author

Seems to be a regression:

https://cdn.jsdelivr.net/npm/@ngneat/[email protected]/lib/formGroup.d.ts

In 1.4.0 the types are correct. In 1.5.0 they become broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant